* [PATCH] allow setting LDFLAGS_FOR_TARGET in top-level configuration.
@ 2011-05-09 8:40 Doug Kwan (關振德)
2011-05-09 8:50 ` H.J. Lu
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Doug Kwan (關振德) @ 2011-05-09 8:40 UTC (permalink / raw)
To: gcc-patches; +Cc: Beare, Bruce J
Hi,
The x86 Android toolchain needs setting LDFLAGS_FOR_TARGET to
build. This patch does that. The patch was tested by bootstrapping
natively on x86_64 linux. Do I also need to submit this to binutils
as well?
-Doug
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] allow setting LDFLAGS_FOR_TARGET in top-level configuration.
2011-05-09 8:40 [PATCH] allow setting LDFLAGS_FOR_TARGET in top-level configuration Doug Kwan (關振德)
@ 2011-05-09 8:50 ` H.J. Lu
2011-05-09 8:59 ` Doug Kwan (關振德)
2011-05-09 12:47 ` Joseph S. Myers
2 siblings, 0 replies; 7+ messages in thread
From: H.J. Lu @ 2011-05-09 8:50 UTC (permalink / raw)
To: Doug Kwan (關振德); +Cc: gcc-patches, Beare, Bruce J
On Sun, May 8, 2011 at 7:31 PM, Doug Kwan (關振德) <dougkwan@google.com> wrote:
> Hi,
>
> The x86 Android toolchain needs setting LDFLAGS_FOR_TARGET to
> build. This patch does that. The patch was tested by bootstrapping
> natively on x86_64 linux. Do I also need to submit this to binutils
> as well?
>
There is no patch.
--
H.J.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] allow setting LDFLAGS_FOR_TARGET in top-level configuration.
2011-05-09 8:40 [PATCH] allow setting LDFLAGS_FOR_TARGET in top-level configuration Doug Kwan (關振德)
2011-05-09 8:50 ` H.J. Lu
@ 2011-05-09 8:59 ` Doug Kwan (關振德)
2011-05-09 9:34 ` Paolo Bonzini
2011-05-09 12:47 ` Joseph S. Myers
2 siblings, 1 reply; 7+ messages in thread
From: Doug Kwan (關振德) @ 2011-05-09 8:59 UTC (permalink / raw)
To: gcc-patches; +Cc: Beare, Bruce J
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
Sorry, forgot the patch and the ChangeLog
2011-05-08 Doug Kwan <dougkwan@google.com>
* configure.ac: Propagate LDFLAGS_FOR_TARGET.
* configure: Regenerated.
* Makefile.tpl (LDFLAGS_FOR_TARGET): Use LDFLAGS_FOR_TARGET
value from configure.
* Makefile.in: Regenerated.
On Sun, May 8, 2011 at 7:31 PM, Doug Kwan (關振德) <dougkwan@google.com> wrote:
> Hi,
>
> The x86 Android toolchain needs setting LDFLAGS_FOR_TARGET to
> build. This patch does that. The patch was tested by bootstrapping
> natively on x86_64 linux. Do I also need to submit this to binutils
> as well?
>
> -Doug
>
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 973 bytes --]
Index: configure.ac
===================================================================
--- configure.ac (revision 173552)
+++ configure.ac (working copy)
@@ -2110,6 +2110,8 @@ if test "x$CXXFLAGS_FOR_TARGET" = x; then
fi
AC_SUBST(CXXFLAGS_FOR_TARGET)
+AC_SUBST(LDFLAGS_FOR_TARGET)
+
# Handle --with-headers=XXX. If the value is not "yes", the contents of
# the named directory are copied to $(tooldir)/sys-include.
if test x"${with_headers}" != x && test x"${with_headers}" != xno ; then
Index: Makefile.tpl
===================================================================
--- Makefile.tpl (revision 173552)
+++ Makefile.tpl (working copy)
@@ -494,7 +494,7 @@ CXXFLAGS_FOR_TARGET = @CXXFLAGS_FOR_TARGET@
LIBCFLAGS_FOR_TARGET = $(CFLAGS_FOR_TARGET)
LIBCXXFLAGS_FOR_TARGET = $(CXXFLAGS_FOR_TARGET) -fno-implicit-templates
-LDFLAGS_FOR_TARGET =
+LDFLAGS_FOR_TARGET = @LDFLAGS_FOR_TARGET@
GOCFLAGS_FOR_TARGET = -O2 -g
FLAGS_FOR_TARGET = @FLAGS_FOR_TARGET@
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] allow setting LDFLAGS_FOR_TARGET in top-level configuration.
2011-05-09 8:59 ` Doug Kwan (關振德)
@ 2011-05-09 9:34 ` Paolo Bonzini
0 siblings, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2011-05-09 9:34 UTC (permalink / raw)
To: "Doug Kwan (關振德)"
Cc: gcc-patches, Beare, Bruce J
On 05/09/2011 04:38 AM, Doug Kwan (關振德) wrote:
> Sorry, forgot the patch and the ChangeLog
>
> 2011-05-08 Doug Kwan<dougkwan@google.com>
>
> * configure.ac: Propagate LDFLAGS_FOR_TARGET.
> * configure: Regenerated.
> * Makefile.tpl (LDFLAGS_FOR_TARGET): Use LDFLAGS_FOR_TARGET
> value from configure.
> * Makefile.in: Regenerated.
Ok.
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] allow setting LDFLAGS_FOR_TARGET in top-level configuration.
2011-05-09 8:40 [PATCH] allow setting LDFLAGS_FOR_TARGET in top-level configuration Doug Kwan (關振德)
2011-05-09 8:50 ` H.J. Lu
2011-05-09 8:59 ` Doug Kwan (關振德)
@ 2011-05-09 12:47 ` Joseph S. Myers
2011-05-09 15:02 ` Paolo Bonzini
2 siblings, 1 reply; 7+ messages in thread
From: Joseph S. Myers @ 2011-05-09 12:47 UTC (permalink / raw)
To: Doug Kwan; +Cc: gcc-patches, Beare, Bruce J
On Sun, 8 May 2011, Doug Kwan wrote:
> Hi,
>
> The x86 Android toolchain needs setting LDFLAGS_FOR_TARGET to
> build. This patch does that. The patch was tested by bootstrapping
> natively on x86_64 linux. Do I also need to submit this to binutils
> as well?
My view is that you don't need to *submit* it separately, but a toplevel
commit to GCC should always be immediately followed by committing the same
changes to the src repository without needing separate approval.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] allow setting LDFLAGS_FOR_TARGET in top-level configuration.
2011-05-09 12:47 ` Joseph S. Myers
@ 2011-05-09 15:02 ` Paolo Bonzini
2011-05-09 15:15 ` Paolo Bonzini
0 siblings, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2011-05-09 15:02 UTC (permalink / raw)
To: Joseph S. Myers; +Cc: Doug Kwan, gcc-patches, Beare, Bruce J
On 05/09/2011 11:49 AM, Joseph S. Myers wrote:
> > The x86 Android toolchain needs setting LDFLAGS_FOR_TARGET to
> > build. This patch does that. The patch was tested by bootstrapping
> > natively on x86_64 linux. Do I also need to submit this to binutils
> > as well?
>
> My view is that you don't need to*submit* it separately, but a toplevel
> commit to GCC should always be immediately followed by committing the same
> changes to the src repository without needing separate approval.
This is correct; but if you want to CC binutils, that's also kind.
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] allow setting LDFLAGS_FOR_TARGET in top-level configuration.
2011-05-09 15:02 ` Paolo Bonzini
@ 2011-05-09 15:15 ` Paolo Bonzini
0 siblings, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2011-05-09 15:15 UTC (permalink / raw)
To: gcc-patches; +Cc: Doug Kwan, gcc-patches, Beare, Bruce J
On 05/09/2011 11:49 AM, Joseph S. Myers wrote:
> > The x86 Android toolchain needs setting LDFLAGS_FOR_TARGET to
> > build. This patch does that. The patch was tested by bootstrapping
> > natively on x86_64 linux. Do I also need to submit this to binutils
> > as well?
>
> My view is that you don't need to*submit* it separately, but a toplevel
> commit to GCC should always be immediately followed by committing the same
> changes to the src repository without needing separate approval.
This is correct; but if you want to CC binutils, that's also kind.
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-05-09 11:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-09 8:40 [PATCH] allow setting LDFLAGS_FOR_TARGET in top-level configuration Doug Kwan (關振德)
2011-05-09 8:50 ` H.J. Lu
2011-05-09 8:59 ` Doug Kwan (關振德)
2011-05-09 9:34 ` Paolo Bonzini
2011-05-09 12:47 ` Joseph S. Myers
2011-05-09 15:02 ` Paolo Bonzini
2011-05-09 15:15 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).