From: Jeffrey Yasskin <jyasskin@google.com>
To: Paolo Carlini <paolo.carlini@oracle.com>
Cc: reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org,
Jason Merrill <jason@redhat.com>,
libstdc++@gcc.gnu.org
Subject: Re: [patch] Fix two C++ errors in libstdc++. (issue4341041)
Date: Thu, 31 Mar 2011 21:34:00 -0000 [thread overview]
Message-ID: <BANLkTimfp-d8U4SR_YjDtz=fMtR4z4wRnA@mail.gmail.com> (raw)
In-Reply-To: <4D94DAC7.8060005@oracle.com>
On Thu, Mar 31, 2011 at 12:49 PM, Paolo Carlini
<paolo.carlini@oracle.com> wrote:
> On 03/31/2011 09:41 PM, Paolo Carlini wrote:
>>>
>>> I think this is a candidate to backport to libstdc++-4.6.1.
>>>
>>> exception_ptr.h needs the forward declaration because it's
>>> included from<typeinfo> before<typeinfo> defines std::type_info.
>>
>> before going ahead with the patch - I'm not at all sure it's enough, for
>> <exception> itself for example
>
> I had a closer look to what we have and indeed the patch seems enough to
> solve the existing issues. Thanks. I think we want indeed to apply the
> patchlet to mainline and 4_6-branch, but my basic puzzlement stays, indeed
> it's the real reason why the problem remained unnoticed for so much time!
Thanks. Is that an OK that I can commit this to mainline and 4_6-branch?
[For libstdc++@ people, the patch is at
http://codereview.appspot.com/4341041 and
http://gcc.gnu.org/ml/gcc-patches/2011-03/msg02261.html]
next prev parent reply other threads:[~2011-03-31 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 19:06 Jeffrey Yasskin
2011-03-31 19:49 ` Paolo Carlini
2011-03-31 20:02 ` Paolo Carlini
2011-03-31 21:34 ` Jeffrey Yasskin [this message]
2011-03-31 22:10 ` Paolo Carlini
2011-03-31 21:26 ` Jason Merrill
2011-03-31 21:28 ` Paolo Carlini
2011-03-31 21:39 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimfp-d8U4SR_YjDtz=fMtR4z4wRnA@mail.gmail.com' \
--to=jyasskin@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).