From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18481 invoked by alias); 27 Apr 2011 17:45:29 -0000 Received: (qmail 18459 invoked by uid 22791); 27 Apr 2011 17:45:27 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Apr 2011 17:45:13 +0000 Received: from kpbe13.cbf.corp.google.com (kpbe13.cbf.corp.google.com [172.25.105.77]) by smtp-out.google.com with ESMTP id p3RHjBcC025321 for ; Wed, 27 Apr 2011 10:45:11 -0700 Received: from ywl41 (ywl41.prod.google.com [10.192.12.41]) by kpbe13.cbf.corp.google.com with ESMTP id p3RHj9aK005535 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Wed, 27 Apr 2011 10:45:10 -0700 Received: by ywl41 with SMTP id 41so835236ywl.32 for ; Wed, 27 Apr 2011 10:45:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.207.30 with SMTP id j30mr1608757anq.86.1303926309440; Wed, 27 Apr 2011 10:45:09 -0700 (PDT) Received: by 10.100.131.8 with HTTP; Wed, 27 Apr 2011 10:45:09 -0700 (PDT) In-Reply-To: References: <20110426224430.D1BC8481B3@thebrac.mtv.corp.google.com> Date: Wed, 27 Apr 2011 18:13:00 -0000 Message-ID: Subject: Re: [patch] Add new -gmlt option for min. debug info with line tables (issue4440072) From: Cary Coutant To: "Joseph S. Myers" Cc: reply@codereview.appspotmail.com, jason@redhat.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg02142.txt.bz2 >> + =A0generate_debug_line_table =3D debug_info_level >=3D DINFO_LEVEL_NOR= MAL; > > set_debug_level should not use global state; this needs to check > opts->x_debug_info_level (not the global debug_info_level) and set > opts->x_generate_debug_line_table. Oops, missed that. Thanks! -cary