From: Laurynas Biveinis <laurynas.biveinis@gmail.com>
To: Basile Starynkevitch <basile@starynkevitch.net>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: PATCH [trunk] gengtype should generate ggc_alloc macros in plugin mode on for plugin files
Date: Fri, 15 Apr 2011 04:24:00 -0000 [thread overview]
Message-ID: <BANLkTimox3n0UViEvk2+85Rqm4XHsUST_Q@mail.gmail.com> (raw)
In-Reply-To: <20110411033552.75423cd2.basile@starynkevitch.net>
2011/4/11 Basile Starynkevitch <basile@starynkevitch.net>:
> On Fri, 8 Apr 2011 19:55:51 +0200
> Basile Starynkevitch <basile@starynkevitch.net> wrote:
>
>> Committed revision 172203 (on trunk).
>>
>> Actually, the above committed patch is better than nothing, but not
>> perfect. It happens to generate ggc_alloc macros for things which are
>> not defined in the plugin (however, this is not a big deal in practice,
>> since it generates some macros in common with those inside
>> gtype-desc.h).
>>
>> I have no clear idea on how to improve it. We could for instance write
>> the ggc_alloc macros only for struct & typedefs defined in the plugin
>> files. We then would need a way to know if a file is a plugin file or
>> not. What do you think?
>
> The attached file improves the situation, by flagging input files and
> generating ggc_alloc macros only relevant to plugin files.
What about include files in plugins? Are these marked as input files?
--
Laurynas
next prev parent reply other threads:[~2011-04-15 3:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 19:54 PATCH [trunk] gengtype should generate ggc_alloc macros in plugin mode Basile Starynkevitch
2011-04-07 2:46 ` Laurynas Biveinis
2011-04-08 5:46 ` Basile Starynkevitch
2011-04-08 6:22 ` Duncan Sands
2011-04-08 12:30 ` Laurynas Biveinis
2011-04-08 17:57 ` Basile Starynkevitch
2011-04-10 18:47 ` Laurynas Biveinis
2011-04-10 18:51 ` Basile Starynkevitch
2011-04-11 1:37 ` PATCH [trunk] gengtype should generate ggc_alloc macros in plugin mode on for plugin files Basile Starynkevitch
2011-04-15 4:24 ` Laurynas Biveinis [this message]
2011-04-15 7:26 ` Basile Starynkevitch
2011-04-19 7:13 ` Laurynas Biveinis
2011-04-19 10:12 ` Basile Starynkevitch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimox3n0UViEvk2+85Rqm4XHsUST_Q@mail.gmail.com \
--to=laurynas.biveinis@gmail.com \
--cc=basile@starynkevitch.net \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).