From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16432 invoked by alias); 15 Apr 2011 03:39:11 -0000 Received: (qmail 16420 invoked by uid 22791); 15 Apr 2011 03:39:11 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-fx0-f47.google.com (HELO mail-fx0-f47.google.com) (209.85.161.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Apr 2011 03:39:07 +0000 Received: by fxm19 with SMTP id 19so1987296fxm.20 for ; Thu, 14 Apr 2011 20:39:06 -0700 (PDT) Received: by 10.223.79.79 with SMTP id o15mr1598851fak.16.1302838746065; Thu, 14 Apr 2011 20:39:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.81.75 with HTTP; Thu, 14 Apr 2011 20:38:46 -0700 (PDT) In-Reply-To: <20110411033552.75423cd2.basile@starynkevitch.net> References: <20110404215335.032d7b9c.basile@starynkevitch.net> <20110408074445.4ee15190.basile@starynkevitch.net> <20110408195551.4804bbfe.basile@starynkevitch.net> <20110411033552.75423cd2.basile@starynkevitch.net> From: Laurynas Biveinis Date: Fri, 15 Apr 2011 04:24:00 -0000 Message-ID: Subject: Re: PATCH [trunk] gengtype should generate ggc_alloc macros in plugin mode on for plugin files To: Basile Starynkevitch Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg01143.txt.bz2 2011/4/11 Basile Starynkevitch : > On Fri, 8 Apr 2011 19:55:51 +0200 > Basile Starynkevitch wrote: > >> Committed revision 172203 (on trunk). >> >> Actually, the above committed patch is better than nothing, but not >> perfect. It happens to generate ggc_alloc macros for things which are >> not defined in the plugin (however, this is not a big deal in practice, >> since it generates some macros in common with those inside >> gtype-desc.h). >> >> I have no clear idea on how to improve it. We could for instance write >> the ggc_alloc macros only for struct & typedefs defined in the plugin >> files. We then would need a way to know if a file is a plugin file or >> not. =C2=A0What do you think? > > The attached file improves the situation, by flagging input files and > generating ggc_alloc macros only relevant to plugin files. What about include files in plugins? Are these marked as input files? --=20 Laurynas