From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23735 invoked by alias); 17 Jun 2011 11:21:09 -0000 Received: (qmail 23534 invoked by uid 22791); 17 Jun 2011 11:21:07 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,TW_CX,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Jun 2011 11:20:49 +0000 Received: from hpaq6.eem.corp.google.com (hpaq6.eem.corp.google.com [172.25.149.6]) by smtp-out.google.com with ESMTP id p5HBKmeG023623 for ; Fri, 17 Jun 2011 04:20:48 -0700 Received: from gyb13 (gyb13.prod.google.com [10.243.49.77]) by hpaq6.eem.corp.google.com with ESMTP id p5HBJJ2J026194 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 17 Jun 2011 04:20:47 -0700 Received: by gyb13 with SMTP id 13so947973gyb.27 for ; Fri, 17 Jun 2011 04:20:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.93.6 with SMTP id v6mr2346229ybl.298.1308309646515; Fri, 17 Jun 2011 04:20:46 -0700 (PDT) Received: by 10.151.142.15 with HTTP; Fri, 17 Jun 2011 04:20:46 -0700 (PDT) In-Reply-To: <20110616185715.CDA091C3548@gchare.mtv.corp.google.com> References: <20110616185715.CDA091C3548@gchare.mtv.corp.google.com> Date: Fri, 17 Jun 2011 12:26:00 -0000 Message-ID: Subject: Re: [pph] Fix cxx_binding streaming logic (issue4646041) From: Diego Novillo To: Gabriel Charette Cc: reply@codereview.appspotmail.com, crowl@google.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01334.txt.bz2 On Thu, Jun 16, 2011 at 18:57, Gabriel Charette wrote: > At the end of pph_out_cxx_binding I could also simply do > pph_out_uchar (stream, PPH_RECORD_END); > instead of > pph_out_cxx_binding_1 (stream, NULL, ref_p); > which has the exact same effect. That's fine. I kind of prefer the way you did it. > 2011-06-16 =C2=A0Gabriel Charette =C2=A0 > > =C2=A0 =C2=A0 =C2=A0 =C2=A0* gcc/cp/pph-streamer-in.c (pph_in_cxx_binding= ): Fix streaming logic. > =C2=A0 =C2=A0 =C2=A0 =C2=A0* gcc/cp/pph-streamer-out.c (pph_out_cxx_bindi= ng): Fix streaming logic. OK, committed in rev 175143. Diego.