From: Diego Novillo <dnovillo@google.com>
To: Chris Demetriou <cgd@google.com>
Cc: reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org
Subject: Re: [google][RFA] add extra text to stack frame warnings (issue4479046)
Date: Thu, 05 May 2011 19:09:00 -0000 [thread overview]
Message-ID: <BANLkTin+Z247+w9qmie0PzzVCZSOueMk0w@mail.gmail.com> (raw)
In-Reply-To: <20110505182734.5CC6A1E819C@cgda.mtv.corp.google.com>
On Thu, May 5, 2011 at 14:27, Chris Demetriou <cgd@google.com> wrote:
> Diego,
>
> I know this is a truly horrible and broken way to do this, but alternatives
> (e.g., NLS) don't really work for us.
>
> bootstrapped without new configuration (x86-64 ubuntu lucid, didn't bother
> to run tests), bootstrapped with option (x86-64 ubuntu lucid, with full
> tests, no regressions). Manually tested that the resulting warning
> looks right, too.
>
>
> OK for google/main?
>
>
> chris
> ---
> [gcc/ChangeLog.google-main]
> 2011-05-05 Chris Demetriou <cgd@google.com>
>
> * doc/install.texi (--with-warn-frame-larger-than-extra-text): New.
> * configure.ac (--with-warn-frame-larger-than-extra-text): New.
> (WARN_FRAME_LARGER_THAN_EXTRA_TEXT): Define.
> * final.c (final_start_function): Use
> WARN_FRAME_LARGER_THAN_EXTRA_TEXT.
> * configure: Regenerate.
> * config.in: Regenerate.
Do we want in google/integration maybe? Or do you see this going to trunk?
OK for either, in any case. Just decide where you think it's best to have.
Diego.
next prev parent reply other threads:[~2011-05-05 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 18:39 Chris Demetriou
2011-05-05 19:09 ` Diego Novillo [this message]
2011-05-05 19:23 ` Andrew Pinski
2011-05-06 8:53 ` Chris Demetriou
2011-05-06 17:09 ` Andrew Pinski
[not found] ` <BANLkTimMdjRDwC7Z-xsAbV4GdJn8gP+QgA@mail.gmail.com>
2011-06-10 8:35 ` Chris Demetriou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTin+Z247+w9qmie0PzzVCZSOueMk0w@mail.gmail.com \
--to=dnovillo@google.com \
--cc=cgd@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).