From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4951 invoked by alias); 5 May 2011 18:48:15 -0000 Received: (qmail 4943 invoked by uid 22791); 5 May 2011 18:48:14 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 May 2011 18:48:00 +0000 Received: from kpbe13.cbf.corp.google.com (kpbe13.cbf.corp.google.com [172.25.105.77]) by smtp-out.google.com with ESMTP id p45IlxqN003255 for ; Thu, 5 May 2011 11:47:59 -0700 Received: from gxk28 (gxk28.prod.google.com [10.202.11.28]) by kpbe13.cbf.corp.google.com with ESMTP id p45IlM9u020738 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 5 May 2011 11:47:58 -0700 Received: by gxk28 with SMTP id 28so1420397gxk.27 for ; Thu, 05 May 2011 11:47:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.14.15 with SMTP id 15mr2526933ybn.70.1304621278097; Thu, 05 May 2011 11:47:58 -0700 (PDT) Received: by 10.151.41.13 with HTTP; Thu, 5 May 2011 11:47:58 -0700 (PDT) In-Reply-To: <20110505182734.5CC6A1E819C@cgda.mtv.corp.google.com> References: <20110505182734.5CC6A1E819C@cgda.mtv.corp.google.com> Date: Thu, 05 May 2011 19:09:00 -0000 Message-ID: Subject: Re: [google][RFA] add extra text to stack frame warnings (issue4479046) From: Diego Novillo To: Chris Demetriou Cc: reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00450.txt.bz2 On Thu, May 5, 2011 at 14:27, Chris Demetriou wrote: > Diego, > > I know this is a truly horrible and broken way to do this, but alternativ= es > (e.g., NLS) don't really work for us. > > bootstrapped without new configuration (x86-64 ubuntu lucid, didn't bother > to run tests), bootstrapped with option (x86-64 ubuntu lucid, with full > tests, no regressions). =C2=A0Manually tested that the resulting warning > looks right, too. > > > OK for google/main? > > > chris > --- > [gcc/ChangeLog.google-main] > 2011-05-05 =C2=A0Chris Demetriou =C2=A0 > > =C2=A0 =C2=A0 =C2=A0 =C2=A0* doc/install.texi (--with-warn-frame-larger-t= han-extra-text): New. > =C2=A0 =C2=A0 =C2=A0 =C2=A0* configure.ac (--with-warn-frame-larger-than-= extra-text): New. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(WARN_FRAME_LARGER_THAN_EXTRA_TEXT): Define. > =C2=A0 =C2=A0 =C2=A0 =C2=A0* final.c (final_start_function): Use > =C2=A0 =C2=A0 =C2=A0 =C2=A0WARN_FRAME_LARGER_THAN_EXTRA_TEXT. > =C2=A0 =C2=A0 =C2=A0 =C2=A0* configure: Regenerate. > =C2=A0 =C2=A0 =C2=A0 =C2=A0* config.in: Regenerate. Do we want in google/integration maybe? Or do you see this going to trunk? OK for either, in any case. Just decide where you think it's best to have. Diego.