From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6204 invoked by alias); 27 May 2011 17:44:08 -0000 Received: (qmail 6193 invoked by uid 22791); 27 May 2011 17:44:07 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,TW_BJ,TW_JC,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 May 2011 17:43:53 +0000 Received: from kpbe11.cbf.corp.google.com (kpbe11.cbf.corp.google.com [172.25.105.75]) by smtp-out.google.com with ESMTP id p4RHhqfs029320 for ; Fri, 27 May 2011 10:43:52 -0700 Received: from pwj3 (pwj3.prod.google.com [10.241.219.67]) by kpbe11.cbf.corp.google.com with ESMTP id p4RHho1U013604 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 27 May 2011 10:43:51 -0700 Received: by pwj3 with SMTP id 3so969787pwj.29 for ; Fri, 27 May 2011 10:43:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.56.16 with SMTP id e16mr382787wfa.74.1306518229997; Fri, 27 May 2011 10:43:49 -0700 (PDT) Received: by 10.142.241.14 with HTTP; Fri, 27 May 2011 10:43:49 -0700 (PDT) In-Reply-To: <4DDF0CC8.8000308@codesourcery.com> References: <20110527022401.F1C91222645@jade.mtv.corp.google.com> <4DDF0CC8.8000308@codesourcery.com> Date: Fri, 27 May 2011 19:09:00 -0000 Message-ID: Subject: Re: [pph] More C++ Tree Nodes (issue4526083) From: Lawrence Crowl To: Nathan Froyd Cc: reply@codereview.appspotmail.com, dnovillo@google.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg02192.txt.bz2 On 5/26/11, Nathan Froyd wrote: > On 05/26/2011 10:24 PM, Lawrence Crowl wrote: >> Index: gcc/cp/cp-objcp-common.c >> =================================================================== >> --- gcc/cp/cp-objcp-common.c (revision 174301) >> +++ gcc/cp/cp-objcp-common.c (working copy) >> @@ -99,6 +99,8 @@ cp_tree_size (enum tree_code code) >> >> case TEMPLATE_INFO: return sizeof (struct >> tree_template_info); >> >> + case TREE_BINFO: return sizeof (struct tree_binfo); >> + >> default: >> gcc_unreachable (); >> } > > This does not look right; TREE_BINFO is a variable-sized structure > (and is not C++-specific in any event). I'd forgotten that. > Maybe you should be using tree_size instead of tree_code_size > someplace? Hm. Possibly. The PPH system is still mostly C, and so C++ parts are being dropped, which could cause a different path further upstream. -- Lawrence Crowl