From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25458 invoked by alias); 20 Jun 2011 16:53:43 -0000 Received: (qmail 25447 invoked by uid 22791); 20 Jun 2011 16:53:42 -0000 X-SWARE-Spam-Status: No, hits=-0.3 required=5.0 tests=AWL,BAYES_20,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,FSL_RU_URL,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,TW_XG X-Spam-Check-By: sourceware.org Received: from mail-ey0-f175.google.com (HELO mail-ey0-f175.google.com) (209.85.215.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Jun 2011 16:53:26 +0000 Received: by eye27 with SMTP id 27so401390eye.20 for ; Mon, 20 Jun 2011 09:53:25 -0700 (PDT) Received: by 10.14.29.10 with SMTP id h10mr2111652eea.35.1308588805331; Mon, 20 Jun 2011 09:53:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.14.95.71 with HTTP; Mon, 20 Jun 2011 09:53:05 -0700 (PDT) In-Reply-To: <8D64F155F1C88743BFDC71288E8E2DA8028E10D8@csomb01.corp.atmel.com> References: <8D64F155F1C88743BFDC71288E8E2DA8028E10D8@csomb01.corp.atmel.com> From: Denis Chertykov Date: Mon, 20 Jun 2011 16:58:00 -0000 Message-ID: Subject: Re: Remove TARGET_HELP hook To: "Weddington, Eric" Cc: Joseph Myers , gcc-patches@gcc.gnu.org, aesok@post.ru, Joerg Wunsch Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01507.txt.bz2 2011/6/20 Weddington, Eric : > > >> -----Original Message----- >> From: Joseph Myers [mailto:joseph@codesourcery.com] >> Sent: Monday, June 20, 2011 9:47 AM >> To: gcc-patches@gcc.gnu.org >> Cc: chertykov@gmail.com; aesok@post.ru; Weddington, Eric >> Subject: Remove TARGET_HELP hook >> >> When moving hooks used in opts.c to the common hooks structure so they >> can be called from the driver, I did not move the TARGET_HELP hook >> because this hook is obsoleted by the generic Enum .opt facility (only >> being used to print list of enumerated arguments to options). >> Instead, this patch converts the one remaining target with a >> TARGET_HELP implementation, AVR, to use Enum for the relevant option >> (with a .def file in the same style as various other targets), and >> removes and poisons the hook. >> >> Bootstrapped with no regressions on x86_64-unknown-linux-gnu, and >> tested building cc1 and xgcc for cross to avr-elf. =C2=A0Will common to >> trunk in the absence of target maintainer objections. > > I assume that this new method still prints out the avr mcu list in a simi= lar fashion? > > I have no overwhelming objections. Though I'd rather wait a little to see= if either Denis or Anatoly have any objections. > > Thanks for doing this work, Joseph. I can not object to this patch. Denis.