From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-291711-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 18562 invoked by alias); 12 May 2011 06:55:14 -0000
Received: (qmail 18536 invoked by uid 22791); 12 May 2011 06:55:13 -0000
X-SWARE-Spam-Status: No, hits=-1.4 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-ew0-f47.google.com (HELO mail-ew0-f47.google.com) (209.85.215.47)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 May 2011 06:54:56 +0000
Received: by ewy5 with SMTP id 5so391166ewy.20        for <gcc-patches@gcc.gnu.org>; Wed, 11 May 2011 23:54:55 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.213.21.2 with SMTP id h2mr478063ebb.51.1305183294920; Wed, 11 May 2011 23:54:54 -0700 (PDT)
Received: by 10.213.108.203 with HTTP; Wed, 11 May 2011 23:54:54 -0700 (PDT)
In-Reply-To: <or8vud84tj.fsf@livre.localdomain>
References: <BANLkTimtQfzWO5xrXuVGYyg4r08b5W1OiA@mail.gmail.com>	<or8vud84tj.fsf@livre.localdomain>
Date: Thu, 12 May 2011 09:44:00 -0000
Message-ID: <BANLkTin6dENgdwWPnX1FF59m9zko+DoLxg@mail.gmail.com>
Subject: Re: [PATCH, SMS 2/3] Skip DEBUG_INSNs while recognizing doloop
From: Revital Eres <revital.eres@linaro.org>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: zaks@il.ibm.com, gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2011-05/txt/msg00882.txt.bz2

Hello,

>> + =A0 =A0if (reg_mentioned_p (reg, insn) && !DEBUG_INSN_P (insn))
>
> It probably makes sense to test for !DEBUG_INSN_P first, since it's much
> cheaper.

Thanks, will commit the following to fix that:

        * modulo-sched.c (doloop_register_get): Check !DEBUG_INSN_P
         first.

Index: modulo-sched.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- modulo-sched.c      (revision 173693)
+++ modulo-sched.c      (working copy)
@@ -316,7 +316,7 @@ doloop_register_get (rtx head ATTRIBUTE_
                              : prev_nondebug_insn (tail));

   for (insn =3D head; insn !=3D first_insn_not_to_check; insn =3D NEXT_INS=
N (insn))
-    if (reg_mentioned_p (reg, insn) && !DEBUG_INSN_P (insn))
+    if (!DEBUG_INSN_P (insn) && reg_mentioned_p (reg, insn))
       {
         if (dump_file)
         {

Revital