From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19604 invoked by alias); 5 May 2011 19:19:49 -0000 Received: (qmail 19596 invoked by uid 22791); 5 May 2011 19:19:49 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-iw0-f175.google.com (HELO mail-iw0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 May 2011 19:19:35 +0000 Received: by iwn10 with SMTP id 10so2519860iwn.20 for ; Thu, 05 May 2011 12:19:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.43.47.195 with SMTP id ut3mr1362166icb.426.1304623174703; Thu, 05 May 2011 12:19:34 -0700 (PDT) Received: by 10.42.201.18 with HTTP; Thu, 5 May 2011 12:19:34 -0700 (PDT) In-Reply-To: References: <20110505182734.5CC6A1E819C@cgda.mtv.corp.google.com> Date: Thu, 05 May 2011 19:23:00 -0000 Message-ID: Subject: Re: [google][RFA] add extra text to stack frame warnings (issue4479046) From: Andrew Pinski To: Diego Novillo Cc: Chris Demetriou , reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00453.txt.bz2 On Thu, May 5, 2011 at 11:47 AM, Diego Novillo wrote: >> OK for google/main? Is there a reason why this cannot be an option that someone passes on the command line of GCC instead of a configure option? Also can you show an example of why this message would be changed? Thanks, Andrew Pinski