public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Diego Novillo <dnovillo@google.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: Xinliang David Li <davidxl@google.com>,
	       Sriraman Tallam <tmsriram@google.com>,
	       reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org
Subject: Re: [google] Patch to support calling multi-versioned functions via new GCC builtin. (issue4440078)
Date: Fri, 06 May 2011 13:38:00 -0000	[thread overview]
Message-ID: <BANLkTin=cDNN7eXUttiHwvNAT7h4a7i2EQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTimQ5Zzm=59sQtNNczqnEFWCzK2w=g@mail.gmail.com>

On Fri, May 6, 2011 at 04:55, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Thu, May 5, 2011 at 7:02 PM, Xinliang David Li <davidxl@google.com> wrote:
>>
>> 2) Support of CallInfo for each callsite. This is an annotation, but
>> more standardized. The callinfo can be used to record information such
>> as call attributes, call side effects, mod-ref information etc ---
>> current gimple_call_flags can be folded into this Info structure.
>
> I don't like generic annotation facilities.  What should passes to with
> annotated stmts that are a) transformed, b) removed?  See RTL notes
> and all the interesting issues they cause.

Likewise.  We kind of tried having them in the early days of gimple
and tree-ssa, but quickly removed them.  Anything that is not a
first-class IL member, makes life difficult.  We have some examples in
PHI nodes and EH regions.  They're a bit to the side, and require
extra code to manage.


Diego.

  reply	other threads:[~2011-05-06 13:25 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29  5:03 Sriraman Tallam
2011-04-29 11:59 ` Richard Guenther
2011-04-29 16:55   ` Xinliang David Li
2011-05-02  9:11     ` Richard Guenther
2011-05-02 16:42       ` Xinliang David Li
2011-05-02 19:12         ` Sriraman Tallam
2011-05-02 19:32           ` Xinliang David Li
2011-05-02 20:38             ` Sriraman Tallam
2011-05-02 20:45               ` Eric Botcazou
2011-05-02 20:51                 ` Sriraman Tallam
2011-05-04 19:50               ` Sriraman Tallam
2011-05-04 22:16                 ` Diego Novillo
2011-05-04 22:19                   ` Sriraman Tallam
2011-05-02 21:34         ` Richard Guenther
2011-05-02 23:08           ` Xinliang David Li
2011-05-03 10:00             ` Richard Guenther
2011-05-03 10:07               ` Richard Guenther
2011-05-03 15:21                 ` Mike Stump
2011-05-03 15:34                   ` Joseph S. Myers
2011-05-03 16:50                     ` Mike Stump
2011-05-03 22:05               ` Xinliang David Li
2011-05-04  9:30                 ` Richard Guenther
2011-05-04 22:20                   ` Xinliang David Li
2011-05-05  9:21                     ` Richard Guenther
2011-05-05 17:08                       ` Xinliang David Li
2011-05-06  9:07                         ` Richard Guenther
2011-05-06 13:38                           ` Diego Novillo [this message]
2011-05-06 18:01                           ` Xinliang David Li
2011-05-07 12:48                             ` Richard Guenther
2011-05-07 18:00                               ` Xinliang David Li
2011-05-07 18:11                                 ` Richard Guenther
2011-04-29 18:46   ` Sriraman Tallam
     [not found]   ` <BANLkTim=oXD7egdy7zzMcTMDAhwnMQ=Kyg@mail.gmail.com>
2011-05-02  9:25     ` Richard Guenther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTin=cDNN7eXUttiHwvNAT7h4a7i2EQ@mail.gmail.com' \
    --to=dnovillo@google.com \
    --cc=davidxl@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=reply@codereview.appspotmail.com \
    --cc=richard.guenther@gmail.com \
    --cc=tmsriram@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).