From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-291350-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 15344 invoked by alias); 6 May 2011 13:25:15 -0000
Received: (qmail 15324 invoked by uid 22791); 6 May 2011 13:25:13 -0000
X-SWARE-Spam-Status: No, hits=-2.2 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,TW_TM,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 May 2011 13:24:57 +0000
Received: from hpaq7.eem.corp.google.com (hpaq7.eem.corp.google.com [172.25.149.7])	by smtp-out.google.com with ESMTP id p46DOtQM032615	for <gcc-patches@gcc.gnu.org>; Fri, 6 May 2011 06:24:55 -0700
Received: from yxm8 (yxm8.prod.google.com [10.190.4.8])	by hpaq7.eem.corp.google.com with ESMTP id p46DOrAs003215	(version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT)	for <gcc-patches@gcc.gnu.org>; Fri, 6 May 2011 06:24:54 -0700
Received: by yxm8 with SMTP id 8so1344525yxm.12        for <gcc-patches@gcc.gnu.org>; Fri, 06 May 2011 06:24:53 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.150.200.7 with SMTP id x7mr3314378ybf.298.1304688293520; Fri, 06 May 2011 06:24:53 -0700 (PDT)
Received: by 10.151.41.13 with HTTP; Fri, 6 May 2011 06:24:53 -0700 (PDT)
In-Reply-To: <BANLkTimQ5Zzm=59sQtNNczqnEFWCzK2w=g@mail.gmail.com>
References: <20110429025248.90D61B21AB@azwildcat.mtv.corp.google.com>	<BANLkTi=VT+1G3LPOWeD3mGxtNzXJ+vgZsw@mail.gmail.com>	<BANLkTimbJJq-JA4VbcmkUhMWuxcba4QwnQ@mail.gmail.com>	<BANLkTiktVHMxx5v7zoS6LmTyuUne6hUSSQ@mail.gmail.com>	<BANLkTi=0Sn57g4HffTmMkdy+TyzzdK5WLw@mail.gmail.com>	<BANLkTi=o-2wkkET7M_-xBwWhENUtPrOLug@mail.gmail.com>	<BANLkTikuefO9Wp54TbW5T0YqCx2_npWTgg@mail.gmail.com>	<BANLkTi=V0in2ihZLmDh7Pfj1K2i5Lxr_fw@mail.gmail.com>	<BANLkTikXjVrFPY7TdejNS7KYvfi1xuKnBA@mail.gmail.com>	<BANLkTi=8SgOvZc6ep4UXdLqtFn3QENMieA@mail.gmail.com>	<BANLkTi=Y64XqqhOqOax6T1DbwgY8uRpgWg@mail.gmail.com>	<BANLkTiks8ud3zzVWEmvyJ0i+W+3-5eSWMA@mail.gmail.com>	<BANLkTimJhEMsEfKHjzjK=oEuJFoLfbtSQA@mail.gmail.com>	<BANLkTimQ5Zzm=59sQtNNczqnEFWCzK2w=g@mail.gmail.com>
Date: Fri, 06 May 2011 13:38:00 -0000
Message-ID: <BANLkTin=cDNN7eXUttiHwvNAT7h4a7i2EQ@mail.gmail.com>
Subject: Re: [google] Patch to support calling multi-versioned functions via new GCC builtin. (issue4440078)
From: Diego Novillo <dnovillo@google.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: Xinliang David Li <davidxl@google.com>,        Sriraman Tallam <tmsriram@google.com>,        reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2011-05/txt/msg00521.txt.bz2

On Fri, May 6, 2011 at 04:55, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Thu, May 5, 2011 at 7:02 PM, Xinliang David Li <davidxl@google.com> wr=
ote:
>>
>> 2) Support of CallInfo for each callsite. This is an annotation, but
>> more standardized. The callinfo can be used to record information such
>> as call attributes, call side effects, mod-ref information etc ---
>> current gimple_call_flags can be folded into this Info structure.
>
> I don't like generic annotation facilities. =C2=A0What should passes to w=
ith
> annotated stmts that are a) transformed, b) removed? =C2=A0See RTL notes
> and all the interesting issues they cause.

Likewise.  We kind of tried having them in the early days of gimple
and tree-ssa, but quickly removed them.  Anything that is not a
first-class IL member, makes life difficult.  We have some examples in
PHI nodes and EH regions.  They're a bit to the side, and require
extra code to manage.


Diego.