From: Chris Demetriou <cgd@google.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: Diego Novillo <dnovillo@google.com>,
reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org
Subject: Re: [google][RFA] add extra text to stack frame warnings (issue4479046)
Date: Fri, 10 Jun 2011 08:35:00 -0000 [thread overview]
Message-ID: <BANLkTinAonUQ+AWjUrusDbXJ+Qb-F13sng@mail.gmail.com> (raw)
In-Reply-To: <BANLkTimMdjRDwC7Z-xsAbV4GdJn8gP+QgA@mail.gmail.com>
[resending plain text. Sorry for the noise.]
[sorry, i got stuck doing a bunch of other things.]
On Fri, May 6, 2011 at 10:05, Andrew Pinski <pinskia@gmail.com> wrote:
>
> On Fri, May 6, 2011 at 1:52 AM, Chris Demetriou <cgd@google.com> wrote:
> > In theory, a more general warning-text-addition mechanism could be useful.
> > e.g. a flag that said "when outputting a warning about flag 'foo',
> > output this additional text" could be useful.
> > However, we haven't felt the need to do this for other warnings.
> >
> > IMO, a general solution along these lines would be solving a problem
> > that ~nobody has. 8-)
>
> We already output the option which enables the warning that seems like
> a general solution.
Yeah. I was going to look into using something similar to implement a
generic text-addition mechanism for warnings... but got stuck in
previously-mentioned bunch of other things. 8-(
I ran out of time, ended up checking this in as-is (after updating the
changelog date and retesting).
I may get back to doing it the better way... but it won't be for a while.
chris
prev parent reply other threads:[~2011-06-10 6:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 18:39 Chris Demetriou
2011-05-05 19:09 ` Diego Novillo
2011-05-05 19:23 ` Andrew Pinski
2011-05-06 8:53 ` Chris Demetriou
2011-05-06 17:09 ` Andrew Pinski
[not found] ` <BANLkTimMdjRDwC7Z-xsAbV4GdJn8gP+QgA@mail.gmail.com>
2011-06-10 8:35 ` Chris Demetriou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinAonUQ+AWjUrusDbXJ+Qb-F13sng@mail.gmail.com \
--to=cgd@google.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gmail.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).