From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18440 invoked by alias); 10 Jun 2011 06:50:49 -0000 Received: (qmail 18424 invoked by uid 22791); 10 Jun 2011 06:50:48 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jun 2011 06:50:27 +0000 Received: from kpbe12.cbf.corp.google.com (kpbe12.cbf.corp.google.com [172.25.105.76]) by smtp-out.google.com with ESMTP id p5A6oPRw020857 for ; Thu, 9 Jun 2011 23:50:26 -0700 Received: from gxk26 (gxk26.prod.google.com [10.202.11.26]) by kpbe12.cbf.corp.google.com with ESMTP id p5A6m4bD017461 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 9 Jun 2011 23:50:24 -0700 Received: by gxk26 with SMTP id 26so1813342gxk.32 for ; Thu, 09 Jun 2011 23:50:24 -0700 (PDT) Received: by 10.101.136.34 with SMTP id o34mr1537605ann.73.1307688624097; Thu, 09 Jun 2011 23:50:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.172.14 with HTTP; Thu, 9 Jun 2011 23:50:04 -0700 (PDT) In-Reply-To: References: <20110505182734.5CC6A1E819C@cgda.mtv.corp.google.com> From: Chris Demetriou Date: Fri, 10 Jun 2011 08:35:00 -0000 Message-ID: Subject: Re: [google][RFA] add extra text to stack frame warnings (issue4479046) To: Andrew Pinski Cc: Diego Novillo , reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00802.txt.bz2 [resending plain text. Sorry for the noise.] [sorry, i got stuck doing a bunch of other things.] On Fri, May 6, 2011 at 10:05, Andrew Pinski wrote: > > On Fri, May 6, 2011 at 1:52 AM, Chris Demetriou wrote: > > In theory, a more general warning-text-addition mechanism could be usef= ul. > > e.g. a flag that said "when outputting a warning about flag 'foo', > > output this additional text" could be useful. > > However, we haven't felt the need to do this for other warnings. > > > > IMO, a general solution along these lines would be solving a problem > > that ~nobody has. =A08-) > > We already output the option which enables the warning that seems like > a general solution. Yeah. =A0I was going to look into using something similar to implement a generic text-addition mechanism for warnings... but got stuck in previously-mentioned bunch of other things. =A08-( I ran out of time, ended up checking this in as-is (after updating the changelog date and retesting). I may get back to doing it the better way... but it won't be for a while. chris