From: Diego Novillo <dnovillo@google.com>
To: Richard Guenther <rguenther@suse.de>
Cc: Jakub Jelinek <jakub@redhat.com>,
reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org
Subject: Re: [lto/pph] Do not pack more bits than requested (issue4415044)
Date: Fri, 15 Apr 2011 12:50:00 -0000 [thread overview]
Message-ID: <BANLkTinT0g0bMm41vSdnS2uJ5-2SEsV06g@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1104151052291.810@zhemvz.fhfr.qr>
On Fri, Apr 15, 2011 at 04:56, Richard Guenther <rguenther@suse.de> wrote:
>> @@ -518,7 +518,8 @@ pack_ts_type_value_fields (struct bitpack_d *bp, tree expr)
>> bp_pack_value (bp, TYPE_USER_ALIGN (expr), 1);
>> bp_pack_value (bp, TYPE_READONLY (expr), 1);
>> bp_pack_value (bp, TYPE_ALIGN (expr), HOST_BITS_PER_INT);
>> - bp_pack_value (bp, TYPE_ALIAS_SET (expr) == 0 ? 0 : -1, HOST_BITS_PER_INT);
>> + bp_pack_value (bp, TYPE_ALIAS_SET (expr) == 0 ? 0 : -1,
>> + BITS_PER_BITPACK_WORD);
>
> As we only want to stream alias-set zeros just change it to a single bit,
> like
>
> bp_pack_value (bp, TYPE_ALIAS_SET (expr) == 0, 1);
>
> and on the reader side restore either a zero or -1.
Ah, yes. Much better.
> As for the -1 case, it's simply broken use of the interface.
Which would've been caught by the assertion. How about this, we keep
the asserts with #ifdef ENABLE_CHECKING. This would've saved me some
ugly debugging.
Diego.
next prev parent reply other threads:[~2011-04-15 12:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 19:01 Diego Novillo
2011-04-14 19:40 ` Jakub Jelinek
2011-04-14 21:04 ` Diego Novillo
2011-04-15 9:13 ` Richard Guenther
2011-04-15 12:50 ` Diego Novillo [this message]
2011-04-15 13:00 ` Richard Guenther
2011-04-15 13:19 ` Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinT0g0bMm41vSdnS2uJ5-2SEsV06g@mail.gmail.com \
--to=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=reply@codereview.appspotmail.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).