From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11421 invoked by alias); 24 Jun 2011 13:12:03 -0000 Received: (qmail 11408 invoked by uid 22791); 24 Jun 2011 13:12:03 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Jun 2011 13:11:49 +0000 Received: from wpaz29.hot.corp.google.com (wpaz29.hot.corp.google.com [172.24.198.93]) by smtp-out.google.com with ESMTP id p5ODBiqM027807 for ; Fri, 24 Jun 2011 06:11:44 -0700 Received: from gyf3 (gyf3.prod.google.com [10.243.50.67]) by wpaz29.hot.corp.google.com with ESMTP id p5ODBgZg008652 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 24 Jun 2011 06:11:43 -0700 Received: by gyf3 with SMTP id 3so1356682gyf.41 for ; Fri, 24 Jun 2011 06:11:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.29.4 with SMTP id g4mr3715186ybj.13.1308921102679; Fri, 24 Jun 2011 06:11:42 -0700 (PDT) Received: by 10.151.142.15 with HTTP; Fri, 24 Jun 2011 06:11:42 -0700 (PDT) In-Reply-To: References: <20110610225101.D18D71DA1CD@topo.tor.corp.google.com> Date: Fri, 24 Jun 2011 13:30:00 -0000 Message-ID: Subject: Re: [pph contrib] Add support for multiple spawn patterns in repro_fail (issue4571061) From: Diego Novillo To: Alexandre Oliva Cc: reply@codereview.appspotmail.com, lxo@redhat.com, crowl@google.com, gchare@google.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01869.txt.bz2 On Tue, Jun 21, 2011 at 14:36, Alexandre Oliva wrote: > On Jun 10, 2011, dnovillo@google.com (Diego Novillo) wrote: > >> I'm thinking that this script is better written in python, but that >> may make it less generic and I don't know whether we accept python in >> gcc/contrib. =C2=A0Alex? > > I guess anything goes in gcc/contrib, so it could be rewritten in > Python, but the bash script you checked in looks good enough to me. Thanks. I committed the script to trunk r175374. Diego.