public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Diego Novillo <dnovillo@google.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: reply@codereview.appspotmail.com, crowl@google.com,
	       gcc-patches@gcc.gnu.org
Subject: Re: [pph] Add streamer hook for preloading common nodes (issue4478043)
Date: Thu, 05 May 2011 11:45:00 -0000	[thread overview]
Message-ID: <BANLkTinWPfA=xEvWCqkDHSaCLLph4Bo9Gw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=aVCjBJdH9x5Q8DtBZVq9nkg7Kbw@mail.gmail.com>

On Thu, May 5, 2011 at 07:07, Richard Guenther
<richard.guenther@gmail.com> wrote:

> For LTO we have type-merging for that, and we'd continue to pre-load
> the type merger with the (LTO frontend specific) common tree nodes.

OK.  For LTO it may make sense to eventually make this hook a nop, then.

> I suppose you are not doing any merging at all?  If so pre-loading those
> nodes makes indeed sense (given you have a way to reject PPH images
> when flags such as -f[un]signed-char differ ...).

There will be some amount of merging, but I'm anticipating using the
same merging scheme used by the parser.  As far as the parser is
concerned, pph images are not much different than a regular header
file.  What changes is the way those declarations get loaded in
memory.


Diego.

      reply	other threads:[~2011-05-05 11:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-04 21:05 Diego Novillo
2011-05-05  9:09 ` Richard Guenther
2011-05-05 11:08   ` Diego Novillo
2011-05-05 11:25     ` Richard Guenther
2011-05-05 11:45       ` Diego Novillo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTinWPfA=xEvWCqkDHSaCLLph4Bo9Gw@mail.gmail.com' \
    --to=dnovillo@google.com \
    --cc=crowl@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=reply@codereview.appspotmail.com \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).