From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7263 invoked by alias); 5 May 2011 11:25:35 -0000 Received: (qmail 7253 invoked by uid 22791); 5 May 2011 11:25:34 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 May 2011 11:25:21 +0000 Received: from wpaz29.hot.corp.google.com (wpaz29.hot.corp.google.com [172.24.198.93]) by smtp-out.google.com with ESMTP id p45BPKtO009620 for ; Thu, 5 May 2011 04:25:20 -0700 Received: from gyf1 (gyf1.prod.google.com [10.243.50.65]) by wpaz29.hot.corp.google.com with ESMTP id p45BPDv7009801 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 5 May 2011 04:25:19 -0700 Received: by gyf1 with SMTP id 1so856253gyf.20 for ; Thu, 05 May 2011 04:25:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.69.34 with SMTP id r34mr1971591yba.355.1304594718936; Thu, 05 May 2011 04:25:18 -0700 (PDT) Received: by 10.151.41.13 with HTTP; Thu, 5 May 2011 04:25:18 -0700 (PDT) In-Reply-To: References: <20110504202659.AD3CFECC6@topo.tor.corp.google.com> Date: Thu, 05 May 2011 11:45:00 -0000 Message-ID: Subject: Re: [pph] Add streamer hook for preloading common nodes (issue4478043) From: Diego Novillo To: Richard Guenther Cc: reply@codereview.appspotmail.com, crowl@google.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00399.txt.bz2 On Thu, May 5, 2011 at 07:07, Richard Guenther wrote: > For LTO we have type-merging for that, and we'd continue to pre-load > the type merger with the (LTO frontend specific) common tree nodes. OK. For LTO it may make sense to eventually make this hook a nop, then. > I suppose you are not doing any merging at all? =C2=A0If so pre-loading t= hose > nodes makes indeed sense (given you have a way to reject PPH images > when flags such as -f[un]signed-char differ ...). There will be some amount of merging, but I'm anticipating using the same merging scheme used by the parser. As far as the parser is concerned, pph images are not much different than a regular header file. What changes is the way those declarations get loaded in memory. Diego.