* [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode.
@ 2011-04-28 2:02 Doug Kwan (關振德)
2011-04-28 9:56 ` Paolo Carlini
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Doug Kwan (關振德) @ 2011-04-28 2:02 UTC (permalink / raw)
To: libstdc++, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
Hi,
This patch causes cxxabi_tweaks.h to be installed in freestanding
mode. We need this because libsupc++ installs cxxabi.h, which
includes cxx_tweaks.h.
-Doug
2011-04-27 Doug Kwan <dougkwan@google.com>
* include/Makefile.am (install-freestanding-headers): Also install
cxxabi_tweaks.h.
* include/Makefile.in: Regnerate.
[-- Attachment #2: patch-cxxabi.txt --]
[-- Type: text/plain, Size: 1378 bytes --]
Index: libstdc++-v3/include/Makefile.in
===================================================================
--- libstdc++-v3/include/Makefile.in (revision 173055)
+++ libstdc++-v3/include/Makefile.in (working copy)
@@ -1584,6 +1584,7 @@ install-freestanding-headers:
$(mkinstalldirs) $(DESTDIR)${gxx_include_dir}
$(mkinstalldirs) $(DESTDIR)${host_installdir}
for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h \
+ ${glibcxx_srcdir}/$(ABI_TWEAKS_SRCDIR)/cxxabi_tweaks.h \
${glibcxx_srcdir}/$(CPU_DEFINES_SRCDIR)/cpu_defines.h; do \
$(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}; done
$(mkinstalldirs) $(DESTDIR)${gxx_include_dir}/${std_builddir}
Index: libstdc++-v3/include/Makefile.am
===================================================================
--- libstdc++-v3/include/Makefile.am (revision 173055)
+++ libstdc++-v3/include/Makefile.am (working copy)
@@ -1200,6 +1200,7 @@ install-freestanding-headers:
$(mkinstalldirs) $(DESTDIR)${gxx_include_dir}
$(mkinstalldirs) $(DESTDIR)${host_installdir}
for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h \
+ ${glibcxx_srcdir}/$(ABI_TWEAKS_SRCDIR)/cxxabi_tweaks.h \
${glibcxx_srcdir}/$(CPU_DEFINES_SRCDIR)/cpu_defines.h; do \
$(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}; done
$(mkinstalldirs) $(DESTDIR)${gxx_include_dir}/${std_builddir}
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode.
2011-04-28 2:02 [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode Doug Kwan (關振德)
@ 2011-04-28 9:56 ` Paolo Carlini
2011-04-28 18:00 ` Doug Kwan (關振德)
2011-04-28 19:13 ` Benjamin Kosnik
2011-04-30 12:11 ` Jonathan Wakely
2 siblings, 1 reply; 6+ messages in thread
From: Paolo Carlini @ 2011-04-28 9:56 UTC (permalink / raw)
To: "Doug Kwan (關振德)"; +Cc: libstdc++, gcc-patches
On 04/28/2011 03:37 AM, Doug Kwan (關振德) wrote:
> Hi,
>
> This patch causes cxxabi_tweaks.h to be installed in freestanding
> mode. We need this because libsupc++ installs cxxabi.h, which
> includes cxx_tweaks.h.
Makes sense. Did you install your other similar tweak to 4_6-branch too?
In that case, I would suggest doing the same for this one too. Please
wait 48 hours though, in case other maintainers have different opinions.
Thanks,
Paolo.
PS: Normally, regenerated files are not posted.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode.
2011-04-28 9:56 ` Paolo Carlini
@ 2011-04-28 18:00 ` Doug Kwan (關振德)
2011-04-28 18:25 ` Paolo Carlini
0 siblings, 1 reply; 6+ messages in thread
From: Doug Kwan (關振德) @ 2011-04-28 18:00 UTC (permalink / raw)
To: Paolo Carlini; +Cc: libstdc++, gcc-patches
Hi,
Thanks. I will wait for 2 days before checking this into trunk.
The previous fix was in the 4.6 release. Can I also check in this fix
into 4.6 branch as well?
-Doug
On Thu, Apr 28, 2011 at 2:34 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> On 04/28/2011 03:37 AM, Doug Kwan (關振德) wrote:
>>
>> Hi,
>>
>> This patch causes cxxabi_tweaks.h to be installed in freestanding
>> mode. We need this because libsupc++ installs cxxabi.h, which
>> includes cxx_tweaks.h.
>
> Makes sense. Did you install your other similar tweak to 4_6-branch too? In
> that case, I would suggest doing the same for this one too. Please wait 48
> hours though, in case other maintainers have different opinions.
>
> Thanks,
> Paolo.
>
> PS: Normally, regenerated files are not posted.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode.
2011-04-28 18:00 ` Doug Kwan (關振德)
@ 2011-04-28 18:25 ` Paolo Carlini
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Carlini @ 2011-04-28 18:25 UTC (permalink / raw)
To: "Doug Kwan (關振德)"; +Cc: libstdc++, gcc-patches
On 04/28/2011 07:16 PM, Doug Kwan (關振德) wrote:
> Hi,
>
> Thanks. I will wait for 2 days before checking this into trunk.
> The previous fix was in the 4.6 release. Can I also check in this fix
> into 4.6 branch as well?
Yes.
Paolo.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode.
2011-04-28 2:02 [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode Doug Kwan (關振德)
2011-04-28 9:56 ` Paolo Carlini
@ 2011-04-28 19:13 ` Benjamin Kosnik
2011-04-30 12:11 ` Jonathan Wakely
2 siblings, 0 replies; 6+ messages in thread
From: Benjamin Kosnik @ 2011-04-28 19:13 UTC (permalink / raw)
To: Doug Kwan; +Cc: libstdc++, gcc-patches
> 2011-04-27 Doug Kwan <dougkwan@google.com>
>
> * include/Makefile.am (install-freestanding-headers): Also
> install cxxabi_tweaks.h.
> * include/Makefile.in: Regnerate.
OK for trunk and 4.6
-benjamin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode.
2011-04-28 2:02 [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode Doug Kwan (關振德)
2011-04-28 9:56 ` Paolo Carlini
2011-04-28 19:13 ` Benjamin Kosnik
@ 2011-04-30 12:11 ` Jonathan Wakely
2 siblings, 0 replies; 6+ messages in thread
From: Jonathan Wakely @ 2011-04-30 12:11 UTC (permalink / raw)
To: Doug Kwan (關振德); +Cc: libstdc++, gcc-patches
On 28 April 2011 02:37, Doug Kwan (關振德) wrote:
> * include/Makefile.in: Regnerate.
Typo: "Regenerate"
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-30 10:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-28 2:02 [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode Doug Kwan (關振德)
2011-04-28 9:56 ` Paolo Carlini
2011-04-28 18:00 ` Doug Kwan (關振德)
2011-04-28 18:25 ` Paolo Carlini
2011-04-28 19:13 ` Benjamin Kosnik
2011-04-30 12:11 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).