From: "H.J. Lu" <hjl.tools@gmail.com>
To: gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org
Subject: Re: PATCH [2/n]: Prepare x32: Convert pointer to TLS symbol if needed
Date: Wed, 29 Jun 2011 17:36:00 -0000 [thread overview]
Message-ID: <BANLkTineB48Aee-eYQzFv=8zQ4wb2EW5HQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTinuPKbSHAfE+DviMYCwhHmqVVk-fg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2136 bytes --]
On Wed, Jun 29, 2011 at 7:06 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Jun 29, 2011 at 1:45 AM, Richard Sandiford
> <richard.sandiford@linaro.org> wrote:
>> "H.J. Lu" <hongjiu.lu@intel.com> writes:
>>> @@ -706,7 +706,13 @@ precompute_register_parameters (int num_actuals, struct arg_data *args,
>>> pseudo now. TLS symbols sometimes need a call to resolve. */
>>> if (CONSTANT_P (args[i].value)
>>> && !targetm.legitimate_constant_p (args[i].mode, args[i].value))
>>> - args[i].value = force_reg (args[i].mode, args[i].value);
>>> + {
>>> + if (GET_MODE (args[i].value) != args[i].mode)
>>> + args[i].value = convert_to_mode (args[i].mode,
>>> + args[i].value,
>>> + args[i].unsignedp);
>>> + args[i].value = force_reg (args[i].mode, args[i].value);
>>> + }
>>
>> But if GET_MODE (args[i].value) != args[i].mode, then the call to
>> targetm.legitimate_constant_p looks wrong. The mode passed in the
>> first argument is supposed to the mode of the second argument.
>>
>> Is there any reason why this and the following:
>>
>> /* If we are to promote the function arg to a wider mode,
>> do it now. */
>>
>> if (args[i].mode != TYPE_MODE (TREE_TYPE (args[i].tree_value)))
>> args[i].value
>> = convert_modes (args[i].mode,
>> TYPE_MODE (TREE_TYPE (args[i].tree_value)),
>> args[i].value, args[i].unsignedp);
>>
>> need to be done in the current order? I can't think of any off-hand.
>> If not, would swapping them also fix the bug?
>>
>> (I can't review this either way, of course.)
>
> It works on the testcase. I will do a full test.
>
It works. There are no regressions on Linux/x86-64.
OK for trunk?
Thanks.
--
H.J.
----
2011-06-29 H.J. Lu <hongjiu.lu@intel.com>
PR middle-end/47715
* calls.c (precompute_register_parameters): Promote the function
argument before checking non-legitimate constant.
[-- Attachment #2: gcc-x32-pr47715-1.patch --]
[-- Type: text/plain, Size: 1452 bytes --]
2011-06-29 H.J. Lu <hongjiu.lu@intel.com>
PR middle-end/47715
* calls.c (precompute_register_parameters): Promote the function
argument before checking non-legitimate constant.
diff --git a/gcc/calls.c b/gcc/calls.c
index bba477c..7538e4e 100644
--- a/gcc/calls.c
+++ b/gcc/calls.c
@@ -702,12 +702,6 @@ precompute_register_parameters (int num_actuals, struct arg_data *args,
pop_temp_slots ();
}
- /* If the value is a non-legitimate constant, force it into a
- pseudo now. TLS symbols sometimes need a call to resolve. */
- if (CONSTANT_P (args[i].value)
- && !targetm.legitimate_constant_p (args[i].mode, args[i].value))
- args[i].value = force_reg (args[i].mode, args[i].value);
-
/* If we are to promote the function arg to a wider mode,
do it now. */
@@ -717,6 +711,12 @@ precompute_register_parameters (int num_actuals, struct arg_data *args,
TYPE_MODE (TREE_TYPE (args[i].tree_value)),
args[i].value, args[i].unsignedp);
+ /* If the value is a non-legitimate constant, force it into a
+ pseudo now. TLS symbols sometimes need a call to resolve. */
+ if (CONSTANT_P (args[i].value)
+ && !targetm.legitimate_constant_p (args[i].mode, args[i].value))
+ args[i].value = force_reg (args[i].mode, args[i].value);
+
/* If we're going to have to load the value by parts, pull the
parts into pseudos. The part extraction process can involve
non-trivial computation. */
next prev parent reply other threads:[~2011-06-29 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-11 15:56 H.J. Lu
2011-06-29 8:55 ` Richard Sandiford
2011-06-29 14:39 ` H.J. Lu
2011-06-29 17:36 ` H.J. Lu [this message]
2011-07-01 16:38 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTineB48Aee-eYQzFv=8zQ4wb2EW5HQ@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).