From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7916 invoked by alias); 23 May 2011 15:46:32 -0000 Received: (qmail 7885 invoked by uid 22791); 23 May 2011 15:46:30 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-ww0-f41.google.com (HELO mail-ww0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 May 2011 15:46:17 +0000 Received: by wwi18 with SMTP id 18so1566148wwi.2 for ; Mon, 23 May 2011 08:46:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.227.174.79 with SMTP id s15mr2420063wbz.76.1306165575695; Mon, 23 May 2011 08:46:15 -0700 (PDT) Received: by 10.227.38.129 with HTTP; Mon, 23 May 2011 08:46:15 -0700 (PDT) In-Reply-To: References: Date: Mon, 23 May 2011 16:19:00 -0000 Message-ID: Subject: Re: [PATCH][last/n] LTO type merging cleanup From: Richard Guenther To: "H.J. Lu" Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01654.txt.bz2 On Mon, May 23, 2011 at 5:34 PM, H.J. Lu wrote: > On Mon, May 23, 2011 at 8:18 AM, Richard Guenther wro= te: >> >> This is the last (planned) bit for the regular type merging machinery >> (there is still some issues with TYPE_CANONICAL that I will try to >> address next). =A0It avoids merging types which have different names >> as that leads to interesting debuginfo issues. >> >> LTO-bootstrapped and tested on x86_64-unknown-linux-gnu, SPEC 2k6 >> non--g built (w/o any but the TYPE_CANONICAL issues), SPEC 2k6 -g >> build running. >> >> Richard. >> >> 2011-05-23 =A0Richard Guenther =A0 >> >> =A0 =A0 =A0 =A0* gimple.c (gimple_types_compatible_p_1): Always compare = type names. >> =A0 =A0 =A0 =A0(iterative_hash_gimple_type): Always hash type names. >> > > Will it fix > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D49078 That's very unlikely as it is a TYPE_CANONICAL issue. Richard.