From: Diego Novillo <dnovillo@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Lawrence Crowl <crowl@google.com>,
reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org
Subject: Re: [pph/libcpp] Allow include callback to not read the file (issue4388057)
Date: Wed, 13 Apr 2011 17:23:00 -0000 [thread overview]
Message-ID: <BANLkTineV_qgH71QpyR4AtOo9fUvLZZf9Q@mail.gmail.com> (raw)
In-Reply-To: <m3oc4a15qz.fsf@fleche.redhat.com>
On Wed, Apr 13, 2011 at 12:21, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Diego" == Diego Novillo <dnovillo@google.com> writes:
>
> Lawrence> This change is not source compatible with existing code using
> Lawrence> the callbacks (which may not be in the gcc svn). Perhaps a new
> Lawrence> callback is needed?
>
> Diego> Well, it only changes the return value for the callback. Existing
> Diego> users do not really need to be changed.
>
> Diego> I don't think we want a new callback. The callback would do exactly
> Diego> what cb.include does.
>
> My grep shows 2 places that set this: c-family/c-ppoutput.c and
> fortran/cpp.c. It seems like it would be simple to just update those
> two functions to account for the type change.
Oh, right. Here I was thinking of users outside of gcc, but of course
there aren't those. I'll fix the calls in the existing front ends.
Diego.
next prev parent reply other threads:[~2011-04-13 17:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 20:28 Diego Novillo
2011-04-13 0:41 ` Lawrence Crowl
2011-04-13 0:50 ` Diego Novillo
2011-04-13 16:22 ` Tom Tromey
2011-04-13 17:23 ` Diego Novillo [this message]
2011-04-13 16:21 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTineV_qgH71QpyR4AtOo9fUvLZZf9Q@mail.gmail.com \
--to=dnovillo@google.com \
--cc=crowl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=reply@codereview.appspotmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).