From: "H.J. Lu" <hjl.tools@gmail.com>
To: Rainer Orth <ro@cebitec.uni-bielefeld.de>
Cc: Richard Henderson <rth@redhat.com>,
Jason Merrill <jason@redhat.com>,
gcc-patches@gcc.gnu.org, Jakub Jelinek <jakub@redhat.com>
Subject: Re: PATCH [8/n]: Prepare x32: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)
Date: Fri, 01 Jul 2011 13:42:00 -0000 [thread overview]
Message-ID: <BANLkTinfLL-Hcpr4JU7UaeD5Tdii8r20xQ@mail.gmail.com> (raw)
In-Reply-To: <yddvcvmrujf.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
On Fri, Jul 1, 2011 at 6:37 AM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
>> On Fri, Jul 1, 2011 at 2:02 AM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>>> "H.J. Lu" <hjl.tools@gmail.com> writes:
>>>
>>>> Here is the updated patch. It works on simple tests.
>>>> I am running full tests. I kept config/i386/value-unwind.h
>>>> since libgcc/md-unwind-support.h is included too late
>>>> in unwind-dw2.c and I don't want to move it to be on
>>>> the safe side.
>>>
>>> Oh please, don't pile hack upon hack to avoid proper testing.
>>>
>>
>> What is your suggestion?
>
> How about moving the md-unwind-support.h include up to the rest of the
> includes? The headers usually only define MD_FALLBACK_FRAME_STATE_FOR
> and perhaps MD_FROB_UPDATE_CONTEXT, everything else is an internal
> helper macro, so order shouldn't matter.
>
It doesn't work on Linux/x86-64:
In file included from
/export/gnu/import/git/gcc/libgcc/../gcc/unwind-dw2.c:39:0:
./md-unwind-support.h: In function \u2018x86_fallback_frame_state\u2019:
./md-unwind-support.h:121:30: error: dereferencing pointer to incomplete type
./md-unwind-support.h:129:17: error: dereferencing pointer to incomplete type
./md-unwind-support.h:141:23: error: dereferencing pointer to incomplete type
./md-unwind-support.h:153:49: error: dereferencing pointer to incomplete type
./md-unwind-support.h: In function \u2018x86_frob_update_context\u2019:
./md-unwind-support.h:185:30: error: dereferencing pointer to incomplete type
./md-unwind-support.h:192:5: warning: implicit declaration of function
\u2018_Unwind_SetSignalFrame\u2019 [-Wimplicit-function-declaration]
/export/gnu/import/git/gcc/libgcc/../gcc/unwind-dw2.c: At top level:
/export/gnu/import/git/gcc/libgcc/../gcc/unwind-dw2.c:140:1: warning:
conflicting types for \u2018_Unwind_SetSignalFrame\u2019 [enabled by
default]
/export/gnu/import/git/gcc/libgcc/../gcc/unwind-dw2.c:140:1: error:
static declaration of \u2018_Unwind_SetSignalFrame\u2019 follows
non-static declaration
./md-unwind-support.h:192:5: note: previous implicit declaration of
\u2018_Unwind_SetSignalFrame\u2019 was here
--
H.J.
next prev parent reply other threads:[~2011-07-01 13:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-25 17:02 H.J. Lu
2011-06-25 23:34 ` Joseph S. Myers
2011-06-25 23:36 ` H.J. Lu
2011-06-26 20:06 ` Jason Merrill
2011-06-26 20:22 ` Jason Merrill
2011-06-26 21:45 ` H.J. Lu
2011-06-27 2:12 ` Jason Merrill
2011-06-27 3:17 ` H.J. Lu
2011-06-27 15:16 ` Jason Merrill
2011-06-28 19:25 ` H.J. Lu
2011-06-30 14:46 ` Jason Merrill
2011-06-30 14:53 ` H.J. Lu
2011-06-30 15:26 ` Jason Merrill
2011-06-30 16:36 ` H.J. Lu
2011-06-30 17:57 ` H.J. Lu
2011-06-30 18:01 ` H.J. Lu
2011-06-30 18:10 ` Rainer Orth
2011-06-30 18:19 ` H.J. Lu
2011-06-30 18:42 ` Rainer Orth
2011-06-30 20:14 ` H.J. Lu
2011-06-30 20:24 ` Richard Henderson
2011-06-30 21:51 ` H.J. Lu
2011-07-01 9:03 ` Rainer Orth
2011-07-01 12:51 ` H.J. Lu
2011-07-01 13:37 ` Rainer Orth
2011-07-01 13:42 ` H.J. Lu [this message]
2011-07-01 14:03 ` Rainer Orth
2011-07-01 14:06 ` H.J. Lu
2011-07-01 14:25 ` Rainer Orth
2011-07-01 14:55 ` H.J. Lu
2011-08-02 21:02 ` Jason Merrill
2011-08-02 22:27 ` H.J. Lu
2011-08-03 21:47 ` Jason Merrill
2011-06-30 20:59 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinfLL-Hcpr4JU7UaeD5Tdii8r20xQ@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=ro@cebitec.uni-bielefeld.de \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).