From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27302 invoked by alias); 10 Jun 2011 08:36:56 -0000 Received: (qmail 27217 invoked by uid 22791); 10 Jun 2011 08:36:55 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-px0-f176.google.com (HELO mail-px0-f176.google.com) (209.85.212.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jun 2011 08:36:40 +0000 Received: by pxi11 with SMTP id 11so1299690pxi.21 for ; Fri, 10 Jun 2011 01:36:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.153.7 with SMTP id f7mr276914wfo.379.1307694999403; Fri, 10 Jun 2011 01:36:39 -0700 (PDT) Received: by 10.143.168.18 with HTTP; Fri, 10 Jun 2011 01:36:39 -0700 (PDT) In-Reply-To: <4DF19363.6030309@redhat.com> References: <4DF19363.6030309@redhat.com> Date: Fri, 10 Jun 2011 08:56:00 -0000 Message-ID: Subject: Re: v3 testsuite PATCH to avoid dg-excess-errors From: Jonathan Wakely To: Jason Merrill Cc: gcc-patches List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00805.txt.bz2 On 10 June 2011 04:45, Jason Merrill wrote: > > Doing this revealed that the bind/ref_neg.cc test was broken; the dg-error > tags were missing a space before the closing }, so they were being ignore= d. > =A0When I fix that, I find that two of the tests are failing. Doh. > I'm committing the first patch, but am holding off on the second for now. > =A0Should I go ahead and commit it or would someone like to fix those bug= s and > then commit it themselves? I'll look at the broken tests asap, but that will be after work in about 8 hours. I'm ok if you want to go ahead and commit the patch, but if you do let's warn HJ that the regression testers will see the FAILs.