From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4159 invoked by alias); 5 May 2011 12:56:41 -0000 Received: (qmail 4146 invoked by uid 22791); 5 May 2011 12:56:41 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,TW_CX X-Spam-Check-By: sourceware.org Received: from mail-gy0-f175.google.com (HELO mail-gy0-f175.google.com) (209.85.160.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 May 2011 12:56:21 +0000 Received: by gyf1 with SMTP id 1so884063gyf.20 for ; Thu, 05 May 2011 05:56:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.170.10 with SMTP id s10mr2294110ybe.76.1304600180935; Thu, 05 May 2011 05:56:20 -0700 (PDT) Received: by 10.147.124.12 with HTTP; Thu, 5 May 2011 05:56:20 -0700 (PDT) In-Reply-To: <20110505125510.GA16164@bromo.med.uc.edu> References: <20110505115439.GA15843@bromo.med.uc.edu> <201105051402.20077.ebotcazou@adacore.com> <20110505125510.GA16164@bromo.med.uc.edu> Date: Thu, 05 May 2011 12:58:00 -0000 Message-ID: Subject: Re: [PATCH} fix --enable-build-with-cxx From: Gabriel Dos Reis To: Jack Howarth Cc: Eric Botcazou , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00412.txt.bz2 On Thu, May 5, 2011 at 7:55 AM, Jack Howarth wro= te: > On Thu, May 05, 2011 at 02:02:19PM +0200, Eric Botcazou wrote: >> > Currently the bootstrap with --enable-build-with-cxx is broken due to >> > compiler errors of the form "error: converting 'false' to pointer type >> > 'varpool_node*' [-Werror=3Dconversion-null]". The attached patch chang= es >> > these instances of false to NULL and restores the --enable-build-with-= cxx >> > bootstrap. Tested on x86_64-apple-darwin10. Okay for gcc trunk? >> >> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00045.html has the first hu= nk so >> you should credit Dmitry. >> >> -- >> Eric Botcazou > > Eric, > =A0 I didn't see that patch so just reduce mine down to the change for ch= ange > for gcc/varpool.c. Odd that the gcc/varpool.c issue isn't seen on other t= argets > besides darwin apparently. the patch is OK as obvious.