From: "H.J. Lu" <hjl.tools@gmail.com>
To: gcc-patches@gcc.gnu.org, patches@linaro.org,
richard.sandiford@linaro.org
Subject: Re: Recording predicate information in all rtl gen* programs
Date: Tue, 12 Apr 2011 14:07:00 -0000 [thread overview]
Message-ID: <BANLkTinqHoNBe7BrxQ9VCk0qikm+aW0+-g@mail.gmail.com> (raw)
In-Reply-To: <g439lnhcvq.fsf@linaro.org>
On Tue, Apr 12, 2011 at 5:28 AM, Richard Sandiford
<richard.sandiford@linaro.org> wrote:
> This patch is a prerequisite for:
>
> http://gcc.gnu.org/ml/gcc-patches/2011-03/msg02168.html
>
> (approved but not yet applied, because I'd forgotten about this).
>
> At the moment, gen* programs that want predicate information need
> to process the DEFINE*_PREDICATE directives themselves. They can then
> use routines in gensupport.c to record and retrieve the processed data.
>
> This patch moves the directive processing into gensupport.c too, so that
> all gen* programs have access to it.
>
> Tested on x86_64-linux-gnu and arm-linux-gnueabi. OK to install?
>
> Richard
>
>
> gcc/
> * genpreds.c (process_define_predicate): Move most processing
> to gensupport.c. Continue to validate the expression.
> * genrecog.c (did_you_mean_codes, compute_predicate_codes)
> (process_define_predicate): Move processing to gensupport.c.
> (main): Remove DEFINE_PREDICATE and DEFINE_SPECIAL_PREDICATE cases.
> * gensupport.c (did_you_mean_codes): Moved from genrecog.c.
> (compute_predicate_codes): Moved from genrecog.c. Add lineno
> argument.
> (valid_predicate_name_p): New function, split out from old
> genpreds.c:process_define_predicate.
> (process_define_predicate): New function, combining code from
> old genpreds.c and genrecog.c functions.
> (process_rtx): Call it for DEFINE_PREDICATE and
> DEFINE_SPECIAL_PREDICATE.
>
>
I think your patch caused:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48573
--
H.J.
next prev parent reply other threads:[~2011-04-12 14:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 12:29 Richard Sandiford
2011-04-12 12:46 ` Bernd Schmidt
2011-04-12 14:07 ` H.J. Lu [this message]
2011-04-12 15:01 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinqHoNBe7BrxQ9VCk0qikm+aW0+-g@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=patches@linaro.org \
--cc=richard.sandiford@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).