From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: varpool alias reorg
Date: Thu, 23 Jun 2011 14:34:00 -0000 [thread overview]
Message-ID: <BANLkTinrjn-RY2vuuJWPypvpd3KS=4PY1A@mail.gmail.com> (raw)
In-Reply-To: <BANLkTimdg0FOWqdfwUfiymqgq3rrC8T_gg@mail.gmail.com>
On Sat, Jun 18, 2011 at 7:19 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sat, Jun 18, 2011 at 1:32 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
>> Hi,
>> this patch makes symetric changes to varpool as did the prevoius series to cgraph.
>> Basically the aliases are now represented as separate varpool nodes with alias reference
>> to the variable they refer to, with some infrastructure to walk the alias references
>> as needed.
>>
>> Bootstrapped/regtested x86_64-linux, comitted.
>>
>> Honza
>>
>> * lto-symtab.c (lto_varpool_replace_node): Remove code handling
>> extra name aliases.
>> (lto_symtab_resolve_can_prevail_p): Likewise.
>> (lto_symtab_merge_cgraph_nodes): Update alias_of pointers.
>> * cgraphbuild.c (record_reference): Remove extra body alias code.
>> (mark_load): Likewise.
>> (mark_store): Likewise.
>> * cgraph.h (varpool_node): Remove extra_name filed;
>> add alias_of and extraname_alias.
>> (varpool_create_variable_alias, varpool_for_node_and_aliases): Declare.
>> (varpool_alias_aliased_node): New inline function.
>> (varpool_variable_node): New function.
>> * cgraphunit.c (handle_alias_pairs): Handle also variable aliases.
>> * ipa-ref.c (ipa_record_reference): Allow aliases on variables.
>> * lto-cgraph.c (lto_output_varpool_node): Update streaming.
>> (input_varpool_node): Likewise.
>> * lto-streamer-out.c (produce_symtab): Remove extra name aliases.
>> (varpool_externally_visible_p): Remove extra body alias code.
>> (function_and_variable_visibility): Likewise.
>> * tree-ssa-structalias.c (associate_varinfo_to_alias_1): New function.
>> (ipa_pta_execute): Use it.
>> * varpool.c (varpool_remove_node): Remove extra name alias code.
>> (varpool_mark_needed_node): Likewise.
>> (varpool_analyze_pending_decls): Analyze aliases.
>> (assemble_aliases): New functoin.
>> (varpool_assemble_decl): Use it.
>> (varpool_create_variable_alias): New function.
>> (varpool_extra_name_alias): Rewrite.
>> (varpool_for_node_and_aliases): New function.
>
> This caused:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463
>
This patch is incorrect as shown in the PR above.
--
H.J.
next prev parent reply other threads:[~2011-06-23 14:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-18 9:11 Jan Hubicka
2011-06-18 14:49 ` H.J. Lu
2011-06-23 14:34 ` H.J. Lu [this message]
2011-06-23 16:44 ` Jan Hubicka
2011-06-24 12:30 ` Jan Hubicka
2011-06-24 12:33 ` Jan Hubicka
2011-06-27 14:08 ` Richard Guenther
2011-06-27 16:13 ` Jan Hubicka
2011-06-27 16:22 ` Michael Matz
2011-06-28 8:34 ` Richard Guenther
2011-06-27 9:43 ` Richard Guenther
2011-06-27 9:50 ` Jan Hubicka
2011-06-22 8:17 ` Regression with "varpool alias reorg" Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTinrjn-RY2vuuJWPypvpd3KS=4PY1A@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).