From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6507 invoked by alias); 16 Apr 2011 16:09:21 -0000 Received: (qmail 6491 invoked by uid 22791); 16 Apr 2011 16:09:19 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 16 Apr 2011 16:09:04 +0000 Received: from kpbe15.cbf.corp.google.com (kpbe15.cbf.corp.google.com [172.25.105.79]) by smtp-out.google.com with ESMTP id p3GG93E0011824 for ; Sat, 16 Apr 2011 09:09:03 -0700 Received: from ywo7 (ywo7.prod.google.com [10.192.15.7]) by kpbe15.cbf.corp.google.com with ESMTP id p3GG92od001384 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Sat, 16 Apr 2011 09:09:02 -0700 Received: by ywo7 with SMTP id 7so1650370ywo.25 for ; Sat, 16 Apr 2011 09:09:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.33.1 with SMTP id l1mr3282041ybj.13.1302970141827; Sat, 16 Apr 2011 09:09:01 -0700 (PDT) Received: by 10.150.212.19 with HTTP; Sat, 16 Apr 2011 09:09:01 -0700 (PDT) In-Reply-To: <20110415020131.0021F222679@jade.mtv.corp.google.com> References: <20110415020131.0021F222679@jade.mtv.corp.google.com> Date: Sat, 16 Apr 2011 17:37:00 -0000 Message-ID: Subject: Re: [pph] Macro Validation Correction (issue4425041) From: Diego Novillo To: Lawrence Crowl Cc: reply@codereview.appspotmail.com, tromey@redhat.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg01277.txt.bz2 On Thu, Apr 14, 2011 at 22:01, Lawrence Crowl wrote: > Unfortunately, five bits are not sufficient for the alternate use of > cpp_hashnode.directive_index as a named operator index. =C2=A0So, I have = reverted > the number of bits from five back to seven. =C2=A0As a result, we now hav= e 34 bits > in small fields, and the size of cpp_hashnode will increase from two to t= hree > words on 32-bit systems. =C2=A0The size on 64-bit systems remains unchang= ed because > these bits go into an alignment gap. I don't think this is a big issue. Tom? > +/* Make sure the bitfield directive_index in include/cpplib.h is large > + =C2=A0 enough to index the entire table. =C2=A0*/ > + > +unsigned char too_many_directives_for_bitfield[ > + =C2=A0 =C2=A0 =C2=A0 =C2=A0N_DIRECTIVES <=3D (1 << CPP_HASHNODE_INDEX_B= ITS) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0? 1 : -1]; Heh, I'm not sure what to think of this trick. I think I like it, though. > +/* Verify that the indicies of the named operators fit within the > + =C2=A0 number of bits available. */ s/indicies/indices/ OK otherwise. Diego.