public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: Thomas Koenig <tkoenig@netcologne.de>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] [4.6/4.7 Regression] Fix PR 48955
Date: Sun, 22 May 2011 20:56:00 -0000	[thread overview]
Message-ID: <BANLkTintJzxP6L8DAMJyKcKNMw4HErOvDQ@mail.gmail.com> (raw)
In-Reply-To: <4DD92C77.5090107@netcologne.de>

Dear Thomas,

I am sorry for the long silence on this PR.  I have been up to my
eyeballs in daytime work.

I have posted a simpler alternative on the PR that uses your
suggestion that forward and backward dependences need to to be
recorded to get this right.

I believe that it's OK but have only now had the opportunity to put it
on to regtest.

Cheers

Paul

On Sun, May 22, 2011 at 5:32 PM, Thomas Koenig <tkoenig@netcologne.de> wrote:
> Hello world,
>
> the attached patch fixes PR 48955, a wrong-code regression for 4.6 and 4.7,
> including the test case from
> http://gcc.gnu.org/ml/fortran/2011-05/msg00093.html .  It follows the
> outline from http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48955#c7 .
>
> Regression-tested. OK for trunk?
>
>        Thomas
>
> 2011-05-22  Thomas Koenig  <tkoenig@gcc.gnu.org>
>
>        PR fortran/48955
>        * gfortran.h (gfc_reverse):  Change to struct with two boolean
>        variables, forward_ok and backward_ok.
>        * trans-expr.c (gfc_trans_assignment_1):  Initialize using
>        new gfc_reverse struct.
>        * trans-array.c (gfc_init_loopinfo):  Likewise.
>        (gfc_trans_scalarized_loop):  Use new gfc_reverse.
>        * dependency.c (gfc_dep_resovler):  Use new gfc_reverse.
>        If a forward dependency is found, a backward dependency is
>        no longer possible and vice versa.
>
> 2011-05-22  Thomas Koenig  <tkoenig@gcc.gnu.org>
>
>        PR fortran/48955
>        * gfortran.dg/dependency_40.f90:  New test.
>
>



-- 
The knack of flying is learning how to throw yourself at the ground and miss.
       --Hitchhikers Guide to the Galaxy

  reply	other threads:[~2011-05-22 18:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-22 18:59 Thomas Koenig
2011-05-22 20:56 ` Paul Richard Thomas [this message]
2011-05-24 22:06   ` Paul Richard Thomas
2011-05-26  9:22     ` Thomas Koenig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTintJzxP6L8DAMJyKcKNMw4HErOvDQ@mail.gmail.com \
    --to=paul.richard.thomas@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tkoenig@netcologne.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).