From: Bruce Korb <bkorb@gnu.org>
To: Douglas B Rupp <rupp@gnat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: How to patch fixincludes/Makefile for Interix?
Date: Fri, 03 Jun 2011 17:17:00 -0000 [thread overview]
Message-ID: <BANLkTinynf==XLMNLjvi6NLo_RrCmFfQ6A@mail.gmail.com> (raw)
In-Reply-To: <4DE9132E.3080205@gnat.com>
Hi Doug,
On Fri, Jun 3, 2011 at 10:00 AM, Douglas B Rupp <rupp@gnat.com> wrote:
>
> I've been working on a resurrection patch for Interix, one remaining problem
> is fixincludes/fixincl.c must be compiled on native Interix with
> -D_ALL_SOURCE in order to find the getpagesize prototype.
>
> This works (taking some liberties with diff...):
>
> fixincludes/Makefile.in
> -FIXINC_CFLAGS = -DHAVE_CONFIG_H $(INCLUDES)
> +FIXINC_CFLAGS = -DHAVE_CONFIG_H $(INCLUDES) -D_ALL_SOURCE
>
> Obviously unacceptable in general.
Obviously.
> Fixincludes ignores a config/mh-interix, so adding
> FIXINC_CFLAGS += -D_ALL_SOURCE doesn't work.
>
> What is the correct solution? Any advice would be greatly appreciated.
Without digging into makefile magic, it would seem to me that
you'd want to jigger Makefile.in to source $(top_srcdir)/config/mh-$(target)
and use FIXINC_CPPFLAGS (this being a pre-processor flag).
next prev parent reply other threads:[~2011-06-03 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 17:01 Douglas B Rupp
2011-06-03 17:17 ` Bruce Korb [this message]
2011-06-04 20:43 ` [PATCH] fixincludes/Makefile for Interix Douglas B Rupp
2011-06-05 17:19 ` Bruce Korb
2011-06-07 4:37 ` [PATCH] fixincludes/Makefile for Interix Rev 2 Douglas B Rupp
2011-06-07 7:20 ` Paolo Bonzini
2011-06-08 6:29 ` [PATCH] fixincludes/Makefile for Interix Rev 3 Douglas B Rupp
2011-06-08 7:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTinynf==XLMNLjvi6NLo_RrCmFfQ6A@mail.gmail.com' \
--to=bkorb@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=rupp@gnat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).