From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 6B328385782A for ; Thu, 29 Sep 2022 16:03:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6B328385782A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wm1-x330.google.com with SMTP id iv17so1277734wmb.4 for ; Thu, 29 Sep 2022 09:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=to:cc:date:message-id:subject:mime-version:from:from:to:cc:subject :date; bh=Zo94TNEH/kkqJb3hlszHEEvOnzKNfGprhjV/1ldUaXI=; b=c5IsJARN2azMk3xDEcIZI6Yie4akmxjc1tnpWZtzH0Wxpjf08Sw3hYwC+BvpFLb+86 u3v5wO9qxIGqFc0fZfDH9k3w2KENIe2x69pmUxiJ04Hh7JnZobrFVs1v2UUwfPMaociX TeVB1dQrr6uU0Gml+hP9Ef6Pe6mwqaAqHJ/sA3Gli7HBJBba76saaLtutO7vG4oEGRkN aU16JuYWPuMXejObUodMy3rfYAx9WkdI9EBSBeks/KM5faNjr/AmdtxgsavoTFwGTfYC mQ7O6UPDojjWh+i7tC9c8jDW98nYaTftRTY+UuBoSxgU/v8vvzWX3UbjogYkl6S/iwbr /kfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version:from:x-gm-message-state :from:to:cc:subject:date; bh=Zo94TNEH/kkqJb3hlszHEEvOnzKNfGprhjV/1ldUaXI=; b=Ww3ZBOmfJJoNfWbBNtP41ZZF+2RtOWlE7w5rih9IPAgcSohKXhsp+pgGOotY645i+t T4+3MaTszqb54Ia5CXsmFg/aWkfyXPAuYVSwfOlVYX/bAD/GfT4VnqqJIIfIQr1aUzqV tsK+7Rfc9CWxLXIkEFI6+Y5cA0xs8Jnkk+YIQj8R5TercC8eNZ7G8KBYCW/FHw0ItE8z CuG5hWVaQVOPLrzAW0RZfxUl6QlCsDsRdNCHjhhYZtWgrfexX/pUPEKWvKzpzkRp7LQC QHgB1WQyx4xfV1VU6z9y1C9chqucsZR/UGpfZ7Dmhzx+Vs4IHgi7FvkYw2VbB/UwMRwP qqjw== X-Gm-Message-State: ACrzQf0+eGNsUX4ueGEvdryHKlnKRLVSP3NtVqzTmTHbuGOMLj4B2QLw dQDap7iaLFkrVEbZ0TE2ax/H1NkU33IKzQ== X-Google-Smtp-Source: AMsMyM6BWgBxOiln/6t/gPkJ+oIlSxPoJAN81r4nlUg6O0BaWmPGEWq6+cexE1NABR4bMTkT74iZuQ== X-Received: by 2002:a05:600c:310b:b0:3b4:c709:4322 with SMTP id g11-20020a05600c310b00b003b4c7094322mr11021260wmo.141.1664467434061; Thu, 29 Sep 2022 09:03:54 -0700 (PDT) Received: from smtpclient.apple ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id x2-20020adfdd82000000b0022ac1be009esm7071555wrl.16.2022.09.29.09.03.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Sep 2022 09:03:52 -0700 (PDT) From: Olivier Hainque Content-Type: multipart/mixed; boundary="Apple-Mail=_1B95005C-9CA3-432B-A409-B22BEDE3F60F" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: [patch] Arrange to --disable-shared by default for VxWorks Message-Id: Date: Thu, 29 Sep 2022 18:03:52 +0200 Cc: Olivier Hainque , Rasmus Villemoes To: gcc-patches X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --Apple-Mail=_1B95005C-9CA3-432B-A409-B22BEDE3F60F Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Hello, Preparing a set of changes to support shared libs for VxWorks (again), this patch makes sure that shared libraries for this family of targets are only built on explicit request, when configured with --enable-shared (by passing down --disable-shared to subdirs otherwise). This provides us with a robust way to guard the relevant pieces in other configure scripts and reduces the risks of accidentally breaking a platform not yet ready for it, should enable-shared be implicitly set without this change. We have been using this for a while now in gcc-11 based production toolchains with and without shared lib support (depending on the CPU). I have performed a couple of build + test checks with gcc-12 for powerpc64, then bootstrapped and regression tested on x86_64-linux. Committing to mainline shortly. Best Regards, Olivier 2022-09-29 Olivier Hainque * configure.ac (*vxworks*): If enable_shared is not set, set to "no" and add --disable-shared to target and host_configargs. * configure: Regenerate. --Apple-Mail=_1B95005C-9CA3-432B-A409-B22BEDE3F60F Content-Disposition: attachment; filename=0008-Arrange-to-disable-shared-by-default-for-VxWorks.patch Content-Type: application/octet-stream; x-unix-mode=0640; name="0008-Arrange-to-disable-shared-by-default-for-VxWorks.patch" Content-Transfer-Encoding: quoted-printable =46rom=2088abceef4baa9360a5042a7b2d7dd99348680c3a=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Olivier=20Hainque=20=0A= Date:=20Fri,=203=20Dec=202021=2017:48:18=20+0000=0ASubject:=20[PATCH=20= 08/18]=20Arrange=20to=20--disable-shared=20by=20default=20for=20VxWorks=0A= =0APreparing=20a=20set=20of=20changes=20to=20support=20shared=20libs=20= for=20VxWorks=20(again),=0Athis=20patch=20makes=20sure=20that=20shared=20= libraries=20for=20this=20family=20of=20targets=0Aare=20only=20built=20on=20= explicit=20request,=20when=20configured=20with=20--enable-shared=0A(by=20= passing=20down=20--disable-shared=20to=20subdirs=20otherwise).=0A=0AThis=20= provides=20us=20with=20a=20robust=20way=20to=20guard=20the=20relevant=20= pieces=20in=0Aother=20configure=20scripts=20and=20reduces=20the=20risks=20= of=20accidentally=20breaking=0Aa=20platform=20not=20yet=20ready=20for=20= it,=20should=20enable-shared=20be=20implicitly=0Aset=20without=20this=20= change.=0A=0A2022-09-29=20=20Olivier=20Hainque=20=20= =0A=0A=09*=20configure.ac=20(*vxworks*):=20If=20= enable_shared=20is=20not=0A=09set,=20set=20to=20"no"=20and=20add=20= --disable-shared=20to=20target=20and=0A=09host_configargs.=0A=09*=20= configure:=20Regenerate.=0A---=0A=20configure=20=20=20=20|=2011=20= +++++++++++=0A=20configure.ac=20|=2011=20+++++++++++=0A=202=20files=20= changed,=2022=20insertions(+)=0A=0Adiff=20--git=20a/configure=20= b/configure=0Aindex=20e7604dc6ff0..d9aa84c6138=20100755=0A---=20= a/configure=0A+++=20b/configure=0A@@=20-10263,6=20+10263,17=20@@=20case=20= "${target}"=20in=0A=20=20=20mep*)=0A=20=20=20=20=20= FLAGS_FOR_TARGET=3D"$FLAGS_FOR_TARGET=20-mlibrary"=0A=20=20=20=20=20;;=0A= +=20=20#=20The=20VxWorks=20support=20for=20shared=20libraries=20is=20= getting=20in=0A+=20=20#=20incrementally.=20=20Make=20sure=20it=20doesn't=20= get=20activated=20implicitly:=0A+=20=20*vxworks*)=0A+=20=20=20=20if=20= test=20"${enable_shared-unset}"=20=3D=20unset=20;=20then=0A+=20=20=20=20=20= =20enable_shared=3Dno=0A+=20=20=20=20=20=20#=20So=20the=20build=20of=20= libraries=20knows=20...=0A+=20=20=20=20=20=20= target_configargs=3D"${target_configargs}=20--disable-shared"=0A+=20=20=20= =20=20=20#=20So=20gcc=20knows=20...=0A+=20=20=20=20=20=20= host_configargs=3D"${host_configargs}=20--disable-shared"=0A+=20=20=20=20= fi=0A+=20=20=20=20;;=0A=20esac=0A=20=0A=20#=20Makefile=20fragments.=0A= diff=20--git=20a/configure.ac=20b/configure.ac=0Aindex=20= 3cfd9b41fca..2cff32e300e=20100644=0A---=20a/configure.ac=0A+++=20= b/configure.ac=0A@@=20-3440,6=20+3440,17=20@@=20case=20"${target}"=20in=0A= =20=20=20mep*)=0A=20=20=20=20=20FLAGS_FOR_TARGET=3D"$FLAGS_FOR_TARGET=20= -mlibrary"=0A=20=20=20=20=20;;=0A+=20=20#=20The=20VxWorks=20support=20= for=20shared=20libraries=20is=20getting=20in=0A+=20=20#=20incrementally.=20= =20Make=20sure=20it=20doesn't=20get=20activated=20implicitly:=0A+=20=20= *vxworks*)=0A+=20=20=20=20if=20test=20"${enable_shared-unset}"=20=3D=20= unset=20;=20then=0A+=20=20=20=20=20=20enable_shared=3Dno=0A+=20=20=20=20=20= =20#=20So=20the=20build=20of=20libraries=20knows=20...=0A+=20=20=20=20=20= =20target_configargs=3D"${target_configargs}=20--disable-shared"=0A+=20=20= =20=20=20=20#=20So=20gcc=20knows=20...=0A+=20=20=20=20=20=20= host_configargs=3D"${host_configargs}=20--disable-shared"=0A+=20=20=20=20= fi=0A+=20=20=20=20;;=0A=20esac=0A=20=0A=20#=20Makefile=20fragments.=0A--=20= =0A2.25.1=0A=0A= --Apple-Mail=_1B95005C-9CA3-432B-A409-B22BEDE3F60F--