From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 60D4C38451A0 for ; Sat, 26 Nov 2022 07:22:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 60D4C38451A0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x42b.google.com with SMTP id z4so9611406wrr.3 for ; Fri, 25 Nov 2022 23:22:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=+v4m+Fx4RLzpOucjHHDuu2B2RASQttXggQ5SLlCGaC0=; b=Y/YljDoHSoecnGGermWTlpAacfeHbL70e4igKDlirJf4i7rF8ycxDV0QrJQ+FWWLmq TEv11n+AG2zKsURy6KYYoRgodf0IXVsKJU4E7Ccv6e4R4RVWOOFNWwrD1VzfUJvRB79t zlZ+dh6n7SLNJCKJkFT4Z6pPBCL5V+gqOcMV8FmmR7OKxo5wTrBpnfY9T7Fr0fFSnkgR THJU5qh/1akqCZJbWl3x9RrGdspq1M4iaftAWgPe2H8g5U0YtGUjL6BRl8oApJsIxX1U Tgn0FagkLUlhtfI5FzNhV7Gel/KXCzMzRqvkNUfZ5yCBpo2R6ys/EflCp46bZW3NCyi7 fdwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+v4m+Fx4RLzpOucjHHDuu2B2RASQttXggQ5SLlCGaC0=; b=CxnpXKH4XKpfcJDqdzzcWoZ8qHClPu4LWdWzmlH4NLYQ5vZxRBQ0Ck8CN4QFgW8Mh9 g7+rwaeunr0Z8Bhfq3g4U6CqP/xtFxfyCK3l4U/hsRZk8PtA59o5aGYFL6nqYl9Bw0J2 EWdfRO1ks+LKfkVDm7AFYgyVroZb7r+XWe0Ov1oaN/dGIFpgz6Ry4CGMdj2/57x0sX1P w/te3x6iu8Ztk0/zNGgl6mprlhFz8WVHTJz4TPFBnyvsHVfuzYh0mJKg5aR7Sl02MUAF nW+asO4bMAHYsqSI5M1SB3j5yxG9D9BflSUA/q0/cLCbS892ax/ZNobYbWY2WQQWat3F 66eQ== X-Gm-Message-State: ANoB5pkxIiKEdRDE5gpRsizQJ4fqBSlBaSy8CvKbA51jvqGvmCkHw70T 5kL46g7dN8mVE7dsuDLSBq6OV2c8syo= X-Google-Smtp-Source: AA0mqf48oiIYqKF+q6wL9/V6e7nCnlzfrrq/UeKTMD3SHocWD3mxL3qyba54NJR05dqKTeeJBpqU8w== X-Received: by 2002:a5d:6891:0:b0:22e:54da:a4f1 with SMTP id h17-20020a5d6891000000b0022e54daa4f1mr25498907wru.637.1669447343689; Fri, 25 Nov 2022 23:22:23 -0800 (PST) Received: from smtpclient.apple (dynamic-095-117-116-094.95.117.pool.telefonica.de. [95.117.116.94]) by smtp.gmail.com with ESMTPSA id n3-20020a05600c3b8300b003cfa81e2eb4sm8671571wms.38.2022.11.25.23.22.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 23:22:22 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Richard Biener Mime-Version: 1.0 (1.0) Subject: Re: [PATCH 16/56] gcc: Re-add TYPE_METHODS. Date: Sat, 26 Nov 2022 08:22:12 +0100 Message-Id: References: Cc: gcc-patches@gcc.gnu.org In-Reply-To: To: Zopolis0 X-Mailer: iPhone Mail (20B101) X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Am 26.11.2022 um 02:55 schrieb Zopolis0 : >=20 > =EF=BB=BFOh wait wrong patch. You talking about binfo confused me. >=20 > Anyways, I re-added this because replacing Java's usage of > TYPE_METHODS with TYPE_FIELDS even when I properly checked for > different types of functions still broke things, so I added this as a > stopgap. >=20 > No idea what you are talking about with binfo though, I added binfo > for the reasons you can see in the email above, nothing to do with > TYPE_METHODS. TYPE_METHODS uses the field used by TYPE_BINFO so the patches are related. I fear you have to understand what the java Frontend does to fix your problem, I certainly don=E2=80=99t know what it do= es wrong here. Re-adding a field to all types is a no-go Richard=20 >=20 >> On Sat, Nov 26, 2022 at 11:16 AM Zopolis0 wro= te: >>=20 >> Because the frontend uses TYPE_BINFO specifically. It expects a TYPE_BINFO= that writes to this value, and will break with replacements. I have tried a= number of alternatives, and this is what works. >>=20 >> I can't use lang_1 because other frontends use it in ways that java doesn= 't expect and I can't create a replacement for TYPE_BINFO because then it wo= n't have the regular checks that TYPE_BINFO has. >>=20 >> I couldn't find a better solution because I'm not particularly versed wit= h the internal workings of gcc, if you can think of a better idea feel free t= o let me know. >>=20 >>> On Sat, 26 Nov 2022 at 07:20, Richard Biener wrote: >>>=20 >>> On Fri, Nov 25, 2022 at 9:55 AM Zopolis0 via Gcc-patches >>> wrote: >>>>=20 >>>=20 >>> Why add this when nothing uses it and you need to re-add binfo because >>> of this? If the frontend uses >>> it then add it to lang_type.