From: "Iyer, Balaji V" <balaji.v.iyer@intel.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, Richard Biener <rguenther@suse.de>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Diego Novillo <dnovillo@google.com>,
"iant@google.com" <iant@google.com>
Subject: RE: [PATCH] Fix PR54659, include gmp.h from system.h
Date: Wed, 09 Jan 2013 02:31:00 -0000 [thread overview]
Message-ID: <BF230D13CA30DD48930C31D40993300016CFFC03@FMSMSX102.amr.corp.intel.com> (raw)
In-Reply-To: <CAMe9rOof8=kp0Q039N7LnAfNeqR9_CjjppqXoM-oxsp8eqMUYA@mail.gmail.com>
> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Tuesday, January 08, 2013 1:50 PM
> To: Richard Biener; Iyer, Balaji V
> Cc: gcc-patches@gcc.gnu.org; Diego Novillo; iant@google.com
> Subject: Re: [PATCH] Fix PR54659, include gmp.h from system.h
>
> On Fri, Dec 21, 2012 at 5:14 AM, Richard Biener <rguenther@suse.de> wrote:
> >
> > After the Ada fix including gmp.h from system.h is trivial (by means
> > of double-int.h it was included from almost everywhere
> > already)
> >
> > Bootstrapped on x86_64-unknown-linux-gnu, testing in progress.
> >
> > Ok for trunk? (Go frontend "unfixed")
> >
> > Thanks,
> > Richard.
> >
> > 2012-12-21 Richard Biener <rguenther@suse.de>
> >
> > PR bootstrap/54659
> > * system.h: Include gmp.h.
> > * tree-ssa-loop-niter.c: Do not include gmp.h here.
> > * double-int.h: Likewise.
> > * realmpfr.h: Likewise.
> >
> > fortran/
> > * gfortran.h: Do not include gmp.h here.
> >
>
> This breaks bootstrap with in-tree gmp since system.h is included for host
> feature test by gcc/configure. Before gmp is built, gmp.h isn't available. We
> need to build gmp first before configuring gcc.
>
> Balaji, can you try this patch?
Yes, this seem to do the trick in my initial runs! Is this already committed to the trunk? If so, I will just merge my branch (cilkplus) with the trunk. Otherwise I have to manually apply it.
Thanks,
Balaji V. Iyer.
>
>
> --
> H.J.
> --
> 2013-01-08 H.J. Lu <hongjiu.lu@intel.com>
>
> * Makefile.def (configure-gcc): Depend on all-gmp.
> (all-gcc): Remove dependency on all-gmp.
> * Makefile.in: Regenerated.
next prev parent reply other threads:[~2013-01-09 2:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 13:15 Richard Biener
2012-12-21 13:17 ` Jakub Jelinek
2012-12-21 16:00 ` Ian Lance Taylor
2013-01-08 18:50 ` H.J. Lu
2013-01-09 2:31 ` Iyer, Balaji V [this message]
2013-01-09 8:36 ` Richard Biener
2012-12-21 16:26 Dominique Dhumieres
2012-12-21 19:03 ` Ian Lance Taylor
2012-12-21 20:06 ` Dominique Dhumieres
2012-12-21 21:20 ` Dominique Dhumieres
2012-12-22 1:56 ` Gerald Pfeifer
2012-12-22 8:55 ` Richard Biener
2012-12-22 9:50 ` Andreas Schwab
2012-12-22 10:43 ` Richard Biener
2012-12-22 10:52 ` Dominique Dhumieres
2012-12-22 11:14 ` Richard Sandiford
2012-12-22 11:03 ` Andreas Schwab
2012-12-27 16:11 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BF230D13CA30DD48930C31D40993300016CFFC03@FMSMSX102.amr.corp.intel.com \
--to=balaji.v.iyer@intel.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=iant@google.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).