From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6607 invoked by alias); 10 Jun 2013 22:16:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6571 invoked by uid 89); 10 Jun 2013 22:16:02 -0000 X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 10 Jun 2013 22:16:01 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 10 Jun 2013 15:16:41 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.19.9.36]) by fmsmga002.fm.intel.com with ESMTP; 10 Jun 2013 15:15:58 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.19.17.7) by FMSMSX105.amr.corp.intel.com (10.19.9.36) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 10 Jun 2013 15:15:58 -0700 Received: from fmsmsx101.amr.corp.intel.com ([169.254.1.135]) by FMSMSX153.amr.corp.intel.com ([169.254.9.202]) with mapi id 14.03.0123.003; Mon, 10 Jun 2013 15:15:58 -0700 From: "Iyer, Balaji V" To: Joseph Myers CC: "gcc-patches@gcc.gnu.org" , Jakub Jelinek , "mpolacek@gcc.gnu.org" Subject: RE: [PATCH] Fix for PR c/57563 Date: Mon, 10 Jun 2013 22:16:00 -0000 Message-ID: References: In-Reply-To: Content-Type: multipart/mixed; boundary="_002_BF230D13CA30DD48930C31D4099330003A42D8CEFMSMSX101amrcor_" MIME-Version: 1.0 X-Virus-Found: No X-SW-Source: 2013-06/txt/msg00539.txt.bz2 --_002_BF230D13CA30DD48930C31D4099330003A42D8CEFMSMSX101amrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-length: 1388 > -----Original Message----- > From: Joseph Myers [mailto:joseph@codesourcery.com] > Sent: Monday, June 10, 2013 5:18 PM > To: Iyer, Balaji V > Cc: gcc-patches@gcc.gnu.org; Jakub Jelinek; mpolacek@gcc.gnu.org > Subject: RE: [PATCH] Fix for PR c/57563 >=20 > On Mon, 10 Jun 2013, Iyer, Balaji V wrote: >=20 > > I looked into it a bit more detail. It was an error on my side. I was > > removing the excess precision expr layer instead of fully folding it. > > I did that change (i.e. fully fold the expression) and all the errors > > seem to go away. Here is the fixed patch that fixes PR c/57563. It > > passes for > > 32 bit and 64 bit tests. Here are the changelog entries: >=20 > This version is better, but if removing an EXCESS_PRECISION_EXPR there ca= used > problems, why is it OK to remove CONVERT_EXPR and NOP_EXPR like you still > do - won't that also cause type mismatches (at least if the conversions a= re to > types that count as sufficiently different for GIMPLE purposes - say conv= ersions > between 32-bit and 64-bit integers)? Maybe you actually need to fold wit= hout > removing any such wrappers first at all? I looked into it and they were an artifact of previous implementation. Thos= e while loops were not even being entered. Thus, I took them out. Here is a= fixed patch.=20 Thanks, Balaji V. Iyer. >=20 > -- > Joseph S. Myers > joseph@codesourcery.com --_002_BF230D13CA30DD48930C31D4099330003A42D8CEFMSMSX101amrcor_ Content-Type: text/plain; name="patch_fix_pr57563.txt" Content-Description: patch_fix_pr57563.txt Content-Disposition: attachment; filename="patch_fix_pr57563.txt"; size=2099; creation-date="Mon, 10 Jun 2013 22:15:17 GMT"; modification-date="Mon, 10 Jun 2013 22:12:49 GMT" Content-Transfer-Encoding: base64 Content-length: 2847 ZGlmZiAtLWdpdCBhL2djYy9jL2MtYXJyYXktbm90YXRpb24uYyBiL2djYy9j L2MtYXJyYXktbm90YXRpb24uYwpvbGQgbW9kZSAxMDA2NDQKbmV3IG1vZGUg MTAwNzU1CmluZGV4IGIxMDQwZGEuLjMyODU5NjkKLS0tIGEvZ2NjL2MvYy1h cnJheS1ub3RhdGlvbi5jCisrKyBiL2djYy9jL2MtYXJyYXktbm90YXRpb24u YwpAQCAtMTQzLDI1ICsxNDMsMTggQEAgZml4X2J1aWx0aW5fYXJyYXlfbm90 YXRpb25fZm4gKHRyZWUgYW5fYnVpbHRpbl9mbiwgdHJlZSAqbmV3X3ZhcikK ICAgICAgIHx8IGFuX3R5cGUgPT0gQlVJTFRfSU5fQ0lMS1BMVVNfU0VDX1JF RFVDRV9NVVRBVElORykKICAgICB7CiAgICAgICBjYWxsX2ZuID0gQ0FMTF9F WFBSX0FSRyAoYW5fYnVpbHRpbl9mbiwgMik7Ci0gICAgICB3aGlsZSAoVFJF RV9DT0RFIChjYWxsX2ZuKSA9PSBDT05WRVJUX0VYUFIKLQkgICAgIHx8IFRS RUVfQ09ERSAoY2FsbF9mbikgPT0gTk9QX0VYUFIpCisgICAgICBpZiAoVFJF RV9DT0RFIChjYWxsX2ZuKSA9PSBBRERSX0VYUFIpCiAJY2FsbF9mbiA9IFRS RUVfT1BFUkFORCAoY2FsbF9mbiwgMCk7Ci0gICAgICBjYWxsX2ZuID0gVFJF RV9PUEVSQU5EIChjYWxsX2ZuLCAwKTsKLSAgICAgIAogICAgICAgaWRlbnRp dHlfdmFsdWUgPSBDQUxMX0VYUFJfQVJHIChhbl9idWlsdGluX2ZuLCAwKTsK LSAgICAgIHdoaWxlIChUUkVFX0NPREUgKGlkZW50aXR5X3ZhbHVlKSA9PSBD T05WRVJUX0VYUFIKLQkgICAgIHx8IFRSRUVfQ09ERSAoaWRlbnRpdHlfdmFs dWUpID09IE5PUF9FWFBSKQotCWlkZW50aXR5X3ZhbHVlID0gVFJFRV9PUEVS QU5EIChpZGVudGl0eV92YWx1ZSwgMCk7CiAgICAgICBmdW5jX3Bhcm0gPSBD QUxMX0VYUFJfQVJHIChhbl9idWlsdGluX2ZuLCAxKTsKICAgICB9CiAgIGVs c2UKICAgICBmdW5jX3Bhcm0gPSBDQUxMX0VYUFJfQVJHIChhbl9idWlsdGlu X2ZuLCAwKTsKICAgCi0gIHdoaWxlIChUUkVFX0NPREUgKGZ1bmNfcGFybSkg PT0gQ09OVkVSVF9FWFBSCi0JIHx8IFRSRUVfQ09ERSAoZnVuY19wYXJtKSA9 PSBFWENFU1NfUFJFQ0lTSU9OX0VYUFIKLQkgfHwgVFJFRV9DT0RFIChmdW5j X3Bhcm0pID09IE5PUF9FWFBSKQotICAgIGZ1bmNfcGFybSA9IFRSRUVfT1BF UkFORCAoZnVuY19wYXJtLCAwKTsKLQorICAvKiBGdWxseSBmb2xkIGFueSBF WENFU1NJVkVfUFJFQ0lTSU9OIEVYUFIgdGhhdCBjYW4gb2NjdXIgaW4gdGhl IGZ1bmN0aW9uCisgICAgIHBhcmFtZXRlci4gICovCisgIGZ1bmNfcGFybSA9 IGNfZnVsbHlfZm9sZCAoZnVuY19wYXJtLCBmYWxzZSwgTlVMTCk7CisgIAog ICBsb2NhdGlvbiA9IEVYUFJfTE9DQVRJT04gKGFuX2J1aWx0aW5fZm4pOwog ICAKICAgaWYgKCFmaW5kX3JhbmsgKGxvY2F0aW9uLCBhbl9idWlsdGluX2Zu LCBhbl9idWlsdGluX2ZuLCB0cnVlLCAmcmFuaykpCmRpZmYgLS1naXQgYS9n Y2MvdGVzdHN1aXRlL2MtYysrLWNvbW1vbi9jaWxrLXBsdXMvQU4vYnVpbHRp bl9mbl9tdXRhdGluZy5jIGIvZ2NjL3Rlc3RzdWl0ZS9jLWMrKy1jb21tb24v Y2lsay1wbHVzL0FOL2J1aWx0aW5fZm5fbXV0YXRpbmcuYwppbmRleCA2NjM1 NTY1Li43YzE5NGMyIDEwMDY0NAotLS0gYS9nY2MvdGVzdHN1aXRlL2MtYysr LWNvbW1vbi9jaWxrLXBsdXMvQU4vYnVpbHRpbl9mbl9tdXRhdGluZy5jCisr KyBiL2djYy90ZXN0c3VpdGUvYy1jKystY29tbW9uL2NpbGstcGx1cy9BTi9i dWlsdGluX2ZuX211dGF0aW5nLmMKQEAgLTQ0LDExICs0NCwxMSBAQCBpbnQg bWFpbih2b2lkKQogICBtYXhfdmFsdWUgPSBhcnJheTNbMF0gKiBhcnJheTRb MF07CiAgIGZvciAoaWkgPSAwOyBpaSA8IDEwOyBpaSsrKQogICAgIGlmIChh cnJheTNbaWldICogYXJyYXk0W2lpXSA+IG1heF92YWx1ZSkgewotICAgICAg bWF4X3ZhbHVlID0gYXJyYXkzW2lpXSAqIGFycmF5NFtpaV07CiAgICAgICBt YXhfaW5kZXggPSBpaTsKICAgICB9CiAgICAgCi0gIAorICBmb3IgKGlpID0g MDsgaWkgPCAxMDsgaWkrKykKKyAgICBteV9mdW5jICgmbWF4X3ZhbHVlLCBh cnJheTNbaWldICogYXJyYXk0W2lpXSk7CiAgIAogI2lmIEhBVkVfSU8KICAg Zm9yIChpaSA9IDA7IGlpIDwgMTA7IGlpKyspIAo= --_002_BF230D13CA30DD48930C31D4099330003A42D8CEFMSMSX101amrcor_--