From: "Iyer, Balaji V" <balaji.v.iyer@intel.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Diego Novillo <dnovillo@google.com>, Jeff Law <law@redhat.com>,
Steven Bosscher <stevenb.gcc@gmail.com>
Subject: RE: gcc's obvious patch policy
Date: Tue, 26 Nov 2013 20:48:00 -0000 [thread overview]
Message-ID: <BF230D13CA30DD48930C31D4099330003A4AC928@FMSMSX101.amr.corp.intel.com> (raw)
In-Reply-To: <12486579.sdiQgXsXIt@polaris>
> -----Original Message-----
> From: Eric Botcazou [mailto:ebotcazou@adacore.com]
> Sent: Tuesday, November 26, 2013 12:33 PM
> To: Iyer, Balaji V
> Cc: gcc-patches@gcc.gnu.org; Diego Novillo; Jeff Law; Steven Bosscher
> Subject: Re: gcc's obvious patch policy
>
> > Can I make a suggestion that if someone is making an "obvious" change
> > (with the exception of changing non-working code (comments, things
> > inside #if 0, etc)), have a patch on the mailing list for 12-24 hrs.
> > before putting it in? Maybe they could say something like, I will
> > check this in by X time <TIMEZONE> tomorrow since this looks obvious
> > to me. This way if the change hurts someone who is working on a
> > feature in their local machine that is using the existing framework can
> chime in.
>
> I disagree, obvious patches cannot reasonably invalidate the work of others,
> or else they are simply not obvious. At worst they can privatize a public
> function or remove an unused one, but then it's easy to undo that later.
>
Those at worst examples you have mentioned is the ones that scare me. Sometimes when a function becomes private, making it public back again is sometimes an uphill battle. I am not saying they shouldn't commit it, but at least give a heads-up.
This being said, I am Ok with either decision.
> --
> Eric Botcazou
next prev parent reply other threads:[~2013-11-26 17:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 10:07 [buildrobot] [PATCH] mips: Really remove ENTRY_BLOCK_PTR Jan-Benedict Glaw
2013-11-20 10:13 ` Richard Sandiford
2013-11-20 10:15 ` Steven Bosscher
2013-11-20 12:13 ` Jan-Benedict Glaw
2013-11-20 18:40 ` [PATCH] Fix comments that refer to ENTRY_{BLOCK|EXIT}_PTR David Malcolm
2013-11-20 19:05 ` Jeff Law
2013-11-21 9:18 ` David Malcolm
2013-11-26 19:39 ` Michael Matz
2013-11-26 8:42 ` gcc's obvious patch policy Alan Modra
2013-11-26 9:59 ` Steven Bosscher
[not found] ` <20131126102146.GA9211@bubble.grove.modra.org>
2013-11-27 1:52 ` David Edelsohn
2013-11-27 2:44 ` Robert Dewar
2013-11-27 8:02 ` Alan Modra
2013-11-27 8:13 ` Richard Kenner
2013-11-27 7:37 ` Alan Modra
2013-11-27 9:04 ` David Edelsohn
2013-11-26 18:34 ` Diego Novillo
2013-11-26 20:16 ` Jeff Law
2013-11-26 20:28 ` Iyer, Balaji V
2013-11-26 20:35 ` James Greenhalgh
2013-11-26 20:39 ` Eric Botcazou
2013-11-26 20:48 ` Iyer, Balaji V [this message]
2013-11-26 20:52 ` Diego Novillo
2013-11-26 20:42 ` Richard Earnshaw
2013-11-26 23:43 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BF230D13CA30DD48930C31D4099330003A4AC928@FMSMSX101.amr.corp.intel.com \
--to=balaji.v.iyer@intel.com \
--cc=dnovillo@google.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=stevenb.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).