From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110945 invoked by alias); 2 Jul 2015 15:37:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 110932 invoked by uid 89); 2 Jul 2015 15:37:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,FREEMAIL_REPLY,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 X-HELO: BLU004-OMC3S22.hotmail.com Received: from blu004-omc3s22.hotmail.com (HELO BLU004-OMC3S22.hotmail.com) (65.55.116.97) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Thu, 02 Jul 2015 15:37:25 +0000 Received: from BLU179-W45 ([65.55.116.74]) by BLU004-OMC3S22.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Thu, 2 Jul 2015 08:37:23 -0700 X-TMN: [iXAwDMt8ssaAhROhru+ij7LfWGinChFP] Message-ID: From: Aditya K To: Tobias Grosser , Sebastian Pop CC: GCC Patches Subject: RE: [PATCH] Discard Scops for which entry==exit Date: Thu, 02 Jul 2015 15:37:00 -0000 In-Reply-To: <5594EDF5.9030404@grosser.es> References: <1435608255-10186-1-git-send-email-hiraditya@msn.com>,,<559232F5.4040206@grosser.es> ,<5594EDF5.9030404@grosser.es> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2015-07/txt/msg00139.txt.bz2 A test case (gcc/testsuite/gcc.dg/graphite/pr18792.c) came up when we remov= ed `graphite-scop-detection.c:limit_scops'. The test case is a scop where entry=3D=3Dexit, BB5 (*#) -> BB6 (#); BB6 -> BB5; In this case BB2 is out of the scop. This is basically an empty (infinite) = loop. 2015-06-29=A0 Aditya Kumar=A0 =A0=A0 =A0=A0=A0=A0 Sebastian Pop =A0=A0=A0=A0=A0=A0=A0 * graphite-scop-detection.c (build_scops_1): Discard = scops for which entry=3D=3Dexit --- =A0gcc/graphite-scop-detection.c | 9 ++++++++- =A01 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gcc/graphite-scop-detection.c b/gcc/graphite-scop-detection.c index e8ddecd..f57cc4a 100644 --- a/gcc/graphite-scop-detection.c +++ b/gcc/graphite-scop-detection.c @@ -810,7 +810,14 @@ build_scops_1 (basic_block current, loop_p outermost_l= oop, =A0=A0=A0=A0 { =A0=A0=A0=A0=A0=A0 open_scop.exit =3D sinfo.exit; =A0=A0=A0=A0=A0=A0 gcc_assert (open_scop.exit); -=A0=A0=A0=A0=A0 scops->safe_push (open_scop); +=A0=A0=A0=A0=A0 if (open_scop.entry !=3D open_scop.exit) +=A0=A0 =A0scops->safe_push (open_scop); +=A0=A0=A0=A0=A0 else +=A0=A0 =A0{ +=A0=A0 =A0=A0 sinfo.difficult =3D true; +=A0=A0 =A0=A0 sinfo.exits =3D false; +=A0=A0 =A0=A0 sinfo.exit =3D NULL; +=A0=A0 =A0} =A0=A0=A0=A0 } =A0 =A0=A0 result.exit =3D sinfo.exit; --=20 2.1.0.243.g30d45f7 ---------------------------------------- > Date: Thu, 2 Jul 2015 09:53:25 +0200 > From: tobias@grosser.es > To: hiraditya@msn.com; sebpop@gmail.com > CC: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Discard Scops for which entry=3D=3Dexit > > On 06/30/2015 05:47 PM, Aditya K wrote: >> Hi Tobias, >> A test case (gcc/testsuite/gcc.dg/graphite/pr18792.c) came up when we re= moved `graphite-scop-detection.c:limit_scops'. >> The test case is a scop where entry=3D=3Dexit, >> >> BB5 (*#) -> BB6 (#); >> BB6 -> BB5; >> >> In this case BB2 is out of the scop. This is basically an empty (infinit= e) loop with no entr > > OK, maybe mention this in the commit message. > > > Best, > Tobias > =20=09=09=20=09=20=20=20=09=09=20=20