From: Aditya K <hiraditya@msn.com>
To: Jakub Jelinek <jakub@redhat.com>, Jeff Law <law@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: RE: Remove splay_tree from gimplify.c
Date: Wed, 27 May 2015 19:54:00 -0000 [thread overview]
Message-ID: <BLU179-W4700B0C0AFE2DC2CDC57F0B6CB0@phx.gbl> (raw)
In-Reply-To: <20150527164155.GJ10247@tucnak.redhat.com>
----------------------------------------
> Date: Wed, 27 May 2015 18:41:55 +0200
> From: jakub@redhat.com
> To: law@redhat.com
> CC: hiraditya@msn.com; gcc-patches@gcc.gnu.org
> Subject: Re: Remove splay_tree from gimplify.c
>
> On Wed, May 27, 2015 at 10:34:46AM -0600, Jeff Law wrote:
>> So the question here is whether or not the other uses are commonly looking
>> up elements we've already searched for -- that's the whole purpose of a
>> splay tree, to improve lookup performance for commonly hit items.
>
> First of all, this is only used for OpenMP/OpenACC/Cilk+ constructs,
> so it really isn't that performance criticial.
> The code probably dates back to Richard's and Diego's changes.
> And, I believe splay trees are the right thing to use here, while sometimes
> you lookup different vars, looking up the same var many times in a row is
> very common.
If that is the case then I guess we can abandon the patch. I do not have a way to measure the compile time for OpenMP.
Thanks for the review.
-Aditya
>
> Jakub
prev parent reply other threads:[~2015-05-27 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 2:52 Aditya K
2015-05-27 16:59 ` Jeff Law
2015-05-27 17:06 ` Jakub Jelinek
2015-05-27 19:54 ` Aditya K [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLU179-W4700B0C0AFE2DC2CDC57F0B6CB0@phx.gbl \
--to=hiraditya@msn.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).