From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60994 invoked by alias); 6 Jul 2015 22:08:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60983 invoked by uid 89); 6 Jul 2015 22:08:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: BLU004-OMC2S31.hotmail.com Received: from blu004-omc2s31.hotmail.com (HELO BLU004-OMC2S31.hotmail.com) (65.55.111.106) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Mon, 06 Jul 2015 22:08:13 +0000 Received: from BLU436-SMTP138 ([65.55.111.73]) by BLU004-OMC2S31.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Mon, 6 Jul 2015 15:08:11 -0700 X-TMN: [fuYsMb7GgytcpmqrBHw7cv4HY90q3t2k] Message-ID: Date: Mon, 06 Jul 2015 22:08:00 -0000 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Bernd Schmidt , Jeff Law , Richard Henderson , jzhang918@gmail.com CC: gcc-patches List Subject: Re: [PATCH] config/bfin/bfin.c (hwloop_optimize): Use return false instead of gcc_assert for checking jump_insn. References: <5591A09A.5050903@codesourcery.com> <5593F08D.6090107@codesourcery.com> <559A79CE.6070809@codesourcery.com> In-Reply-To: <559A79CE.6070809@codesourcery.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00424.txt.bz2 On 7/6/15 20:51, Bernd Schmidt wrote: > On 07/03/2015 04:13 AM, Chen Gang wrote: >> On 07/01/2015 11:27 PM, Chen Gang wrote: >>> On 7/1/15 21:52, Bernd Schmidt wrote: >>>> Below is a patch. Can you test this with anything you have beyond the testsuite? >>>> >>> >>> It can fix this issue (Bug66620), let the insns standard, and can build >>> the bfin kernel with allmodconfig successfully (although for bfin kernel >>> members, they stick to allmodconfig is not a good idea for bfin kernel). >>> >>> It finished lsetup optimization for one loop, but still left the other ( >>> get the same .s as my original fix). for 2nd times in hwloop_optimize, it >>> return false. And welcome any additional ideas for it. >>> >> >> I shall continue to analyse why 2nd lsetup optimiation has not happened. >> Hope I can finish within next week (2015-07-12). > > I've committed my patch after testing bfin-elf. There's no great mystery why the second optimization doesn't happen: the point where it thinks it has to insert the LSETUP is after the loop, and the instruction doesn't allow that. Possibly we could change that - when the loop is entered at the top but not through a fallthrough edge, we could make a new block ahead of it and put the LSETUP in there. > OK, thanks. for me, the fix is enough for this issue. And need we add the related .i file to testsuite, too? And thank you for your information, I shall try to let 2nd times lsetup have effect in another patch, hope I can succeed :-). Thanks -- Chen Gang Open, share, and attitude like air, water, and life which God blessed