From: "rohitarulraj@freescale.com" <rohitarulraj@freescale.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"rguenther@suse.de" <rguenther@suse.de>,
Jakub Jelinek <jakub@redhat.com>
Cc: Alan Modra <amodra@gmail.com>, David Edelsohn <dje.gcc@gmail.com>,
"Edmar Wienskoski" <edmar@freescale.com>,
"rohitarulraj@freescale.com" <rohitarulraj@freescale.com>
Subject: RE: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2
Date: Tue, 28 Apr 2015 10:06:00 -0000 [thread overview]
Message-ID: <BLUPR03MB1458002E9FF7B37BD72093E5C2E80@BLUPR03MB1458.namprd03.prod.outlook.com> (raw)
In-Reply-To: <BLUPR03MB14584D4240675B763002EA5FC2090@BLUPR03MB1458.namprd03.prod.outlook.com>
Ping.
-----Original Message-----
From: Dharmakan Rohit-B30502
Sent: Friday, March 27, 2015 7:57 PM
To: gcc-patches@gcc.gnu.org; rguenther@suse.de; Jakub Jelinek
Cc: Alan Modra; David Edelsohn; Wienskoski Edmar-RA8797; Dharmakan Rohit-B30502
Subject: RE: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2
Hi,
I would like to resubmit these patches for comments. The previous detailed discussion is available in the below mentioned link.
https://gcc.gnu.org/ml/gcc-patches/2014-04/msg01679.html
https://gcc.gnu.org/ml/gcc-patches/2014-05/msg00489.html
The issue is still reproducible on GCC v4.8 branch.
I have tested both the attached patches with e500v2 tool chain on GCC v4.8 branch [rev 221667] and GCC trunk [rev 221310] with no regressions.
Patch1 [gcc.fix_pr60158_fixup_table_fsf_1]: Pass actual alignment value to output_constant_pool_2.
Patch2 [gcc.fix_pr60158_fixup_table_fsf_2]: Use the alignment data available in the first argument (constant_descriptor_rtx) of output_constant_pool_1.
(Note: this generates ".align" directive twice).
Please let me know your comments.
Regards,
Rohit
-----Original Message-----
From: Dharmakan Rohit-B30502
Sent: Wednesday, June 04, 2014 4:46 PM
To: gcc-patches@gcc.gnu.org
Subject: RE: [Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2
Ping.
I have changed the subject line accordingly.
Regards,
Rohit
> -----Original Message-----
> From: David Edelsohn [mailto:dje.gcc@gmail.com]
> Sent: Thursday, May 08, 2014 9:28 PM
> To: Dharmakan Rohit-B30502; Jakub Jelinek; Richard Biener
> Cc: Alan Modra; gcc-patches@gcc.gnu.org; Wienskoski Edmar-RA8797
> Subject: Re: [Patch, PR 60158] Generate .fixup sections for
> .data.rel.ro.local entries.
>
> Rohit,
>
> The subject line and thread may confuse people that this is a PowerPC-
> specific issue. You need approval from a reviewer with authority over
> varasm.c.
>
> Thanks, David
>
> On Thu, May 8, 2014 at 9:54 AM, rohitarulraj@freescale.com
> <rohitarulraj@freescale.com> wrote:
> >> -----Original Message-----
> >> From: Alan Modra [mailto:amodra@gmail.com]
> >> Sent: Saturday, April 26, 2014 11:52 AM
> >> To: Dharmakan Rohit-B30502
> >> Cc: gcc-patches@gcc.gnu.org; dje.gcc@gmail.com; Wienskoski
> >> Edmar-RA8797
> >> Subject: Re: [Patch, PR 60158] Generate .fixup sections for
> >> .data.rel.ro.local entries.
> >>
> >> On Fri, Apr 25, 2014 at 02:57:38PM +0000,
> >> rohitarulraj@freescale.com
> >> wrote:
> >> > Source file: gcc-4.8.2/gcc/varasm.c @@ -7120,7 +7120,7 @@
> >> > if (CONSTANT_POOL_ADDRESS_P (symbol))
> >> > {
> >> > desc = SYMBOL_REF_CONSTANT (symbol);
> >> > output_constant_pool_1 (desc, 1);
> >> ------------- (A)
> >> > offset += GET_MODE_SIZE (desc->mode);
> >>
> >> I think the reason 1 is passed here for align is that with
> >> -fsection- anchors, in output_object_block we've already laid out
> >> everything in the block, assigning offsets from the start of the
> >> block. Aligning shouldn't be necessary, because we've already done
> >> that.. OTOH, it shouldn't hurt to align again.
> >>
> > Thanks. I have tested for both the cases on e500v2, e500mc, e5500,
> ppc64 (GCC v4.8.2 branch) with no regressions.
> >
> > Patch1 [gcc.fix_pr60158_fixup_table-fsf]: Pass actual alignment
> > value
> to output_constant_pool_2.
> > Patch2 [gcc.fix_pr60158_fixup_table-fsf-2]: Use the alignment data
> available in the first argument (constant_descriptor_rtx) of
> output_constant_pool_1.
> > (Note: this generates ".align" directive twice).
> >
> > Is it ok to commit? Any comments?
> >
> > Regards,
> > Rohit
> >
next prev parent reply other threads:[~2015-04-28 9:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 14:27 rohitarulraj
2015-04-28 10:06 ` rohitarulraj [this message]
2015-04-28 18:37 ` Jeff Law
2015-04-28 18:46 ` rohitarulraj
2015-04-28 22:46 ` Jeff Law
2015-04-29 10:43 ` rohitarulraj
2015-04-30 15:15 ` Jeff Law
2015-04-30 15:44 ` rohitarulraj
2015-04-30 15:55 ` Jeff Law
2015-05-05 7:59 ` rohitarulraj
2015-05-15 5:01 ` Jeff Law
2015-05-15 10:38 ` Dharmakan Rohit Arul Raj
2015-05-15 17:53 ` Jeff Law
2015-05-18 8:00 ` Richard Biener
2015-05-25 8:21 ` Dharmakan Rohit Arul Raj
2015-05-26 8:49 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLUPR03MB1458002E9FF7B37BD72093E5C2E80@BLUPR03MB1458.namprd03.prod.outlook.com \
--to=rohitarulraj@freescale.com \
--cc=amodra@gmail.com \
--cc=dje.gcc@gmail.com \
--cc=edmar@freescale.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).