From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-obe.outbound.protection.outlook.com (mail-centralusazon11021017.outbound.protection.outlook.com [52.101.62.17]) by sourceware.org (Postfix) with ESMTPS id C1C7A3858D28 for ; Sun, 30 Jan 2022 10:16:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C1C7A3858D28 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OaUcQmP+VSJep0MWW6EiKM5lrKvMDfe0oS2tWi9jaUPOJVshsBRhBPfkyBIhZwlpmms9W2OvGNh2u6adM5XlFVOpmgMhUpiyAtPVv/W2phwz6wKYO+hnQUFABl4FSQLlInTvzxOKmJfJz6sixhBTJb47zhFKK71uOwdeH47PFjAgB97Wux6ikIPKad8/+gVFalKvnFw9UhfglyuJvHscF4CAF+AdNHrH//kzC+T5biMjNMNlOL12jsqoLHO1pY2TqN5CJ6hmfGLfkWFI0z4sFNiWK2AnmyhqPWajGDk0++ak+YMmA6hUqSXfFZ3/KQ+euj28TKIiuDz4y3XWmAaVJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rQySKi2fCNGymkY800LYe5igLtIY2xPR3ZVcqrma3cU=; b=iqYYKtv8Z/9F8RMBn+b70LUEeBacX9dzwJ4UGra6UtrRkm+a3/t6hd8zFjZ299JvCtSUfoxDCZ+uHgUj+NbR6nlFL6bTqgYlAeyOMhtSD1tD4e7K4ldls+BRk/yLEmUbpNfLb/wIaAT51Fuu17mJfaQ/FHvO9yRsH215DWluQ/rft55gpC9HTBuvbVhjglbP2BGrxch8l++HKlyxLNucOqa7MI3PfRBy7lhEoVz968546KTduCyHsmVFd5zKYsRI29rh0yKBHAMWaTa9jPSJtz58viZTQgnv7g3RiGAAr6I0eMEbeW/HqyvC7lbbJ/wFg1CuYMXFePA3nmFU9xXR9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BN6PR21MB0162.namprd21.prod.outlook.com (2603:10b6:404:94::8) by DM5PR21MB1849.namprd21.prod.outlook.com (2603:10b6:3:91::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.3; Sun, 30 Jan 2022 10:16:44 +0000 Received: from BN6PR21MB0162.namprd21.prod.outlook.com ([fe80::6066:4dae:131a:24b3]) by BN6PR21MB0162.namprd21.prod.outlook.com ([fe80::6066:4dae:131a:24b3%9]) with mapi id 15.20.4975.003; Sun, 30 Jan 2022 10:16:44 +0000 From: Navid Rahimi To: Jakub Jelinek , Richard Biener , Jeff Law CC: "gcc-patches@gcc.gnu.org" Subject: Re: [EXTERNAL] [PATCH] testsuite: Fix up tree-ssa/pr103514.c testcase [PR103514] Thread-Topic: [EXTERNAL] [PATCH] testsuite: Fix up tree-ssa/pr103514.c testcase [PR103514] Thread-Index: AQHYFS/Spfl84gXYLEOw4tmQFy+Ymqx7Wbvk Date: Sun, 30 Jan 2022 10:16:44 +0000 Message-ID: References: <20220129164609.GX2646553@tucnak> In-Reply-To: <20220129164609.GX2646553@tucnak> Accept-Language: en-US Content-Language: en-CA X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-01-30T10:13:39.8406445Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e89322d9-207d-428d-7e4c-08d9e3d99da3 x-ms-traffictypediagnostic: DM5PR21MB1849:EE_ x-ms-exchange-atpmessageproperties: SA|SL x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iRylgmECzDqI1zd4TNHGk5o/3/uWGxsg6dt0EWb74PvKAVNOaJl3Aian55fAp9jarZX1anHFIzvt8ypnWGiCjm6AndDeMpMv2uHJxUQ0P73OhxozjXHi6dqjZWguEiJmJhoAVISlwzsj2uvz+585n4AYcYKltP5tSf2WC62KlU52l8TaAvat2MhX1Hxz/e2HtbE3QL+QPWVWsY94rbS9ZSTC+YlEA5/Be0dtRo4yDElNGFGH+cLsJhgPappjJXX63CrLAPcEfiUab5P1LBfMCCHV3rGDleiFjyxcfQge4D+eICxP3+O2kJnQKfEP7mS/RwY0dup6FrRP0ETWemGOOPhAX/96wuwPoCg314/VpH2M/FnicQJij+p8FQZNWqrQw9s9+jpNY6SSzdUw8APMm89O50AwEnjzVlPPqd88CDJHev8A2Kyu5PywEBdgzBTWA0ac7C/A21DE+mUoheiStBYLqSN8Vw+j0TOIsf8zEL+AQHbPkF0QgGhru+JMjAFtD7z6zLlOhU0pxS3dT5Pxm1XPpWbdBtJJkYtRQTGYgZr27r4G1r0fDqs1rgWMVi7pXFWkCuDXcWEoJ/3BCGqVX80PJIDzeL5B9BlAC6f75RGWI+Tq8eqqUhUGArfcfVHs0ztDn4BSqgRmJpPgg+u6FP8rOXjtdAbCBIIHrA4g68BO6MdsngyCJ+JmUxio3sRMwkB28acVHMr4myMsQaLLnwFdQIcDYd0psl/CEdRNP+hTNbO6RtBw27wXhIQIqx6KWJcDpvqj2xyR+o8b2QZfjqiLtxdH73rYXOa0fyyN3dqTkyhXfpFVY3FrH2w8EGpPOlyiG5cxaN/y5OL+qFdiBCSI4d74uwjHNVJ6HGDDnU7qtxN6TQ/2T7oyl56Xq4iP x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR21MB0162.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66446008)(33656002)(53546011)(186003)(38070700005)(316002)(8936002)(110136005)(66946007)(76116006)(82960400001)(66556008)(66476007)(52536014)(71200400001)(64756008)(38100700002)(86362001)(82950400001)(91956017)(8676002)(4326008)(55016003)(83380400001)(2906002)(8990500004)(5660300002)(122000001)(966005)(10290500003)(508600001)(166002)(84970400001)(6506007)(9686003)(7696005)(10090945008)(20210929001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?dEu5LBslQi9kmT6U3f8ttALZFHa37P7qjMmpo0Kfo/FnB4QsD5M5VxPF?= =?Windows-1252?Q?HAPKR+lTd3N5OqRgXn1nO+i8YBxvxO30MqarrgCAaxUUG5mZ8Xxejrl3?= =?Windows-1252?Q?nejcGc0qllM/lsiVaj8/rVmOETFlSHAFpM6UYa6wwsCBouBUxw6dt9t2?= =?Windows-1252?Q?2CRvy7eTvHdY7Uqs5H2uSzGLkZPc+BcWoRqYUmwEBhm2kR6qLNUdmX+Y?= =?Windows-1252?Q?MetIyDJIe/xvw6azmXitqflM/RBuc6Fpntk+Qum7gQceTafnKiZ/K4l8?= =?Windows-1252?Q?+TwN9FhduXU1JBehUB3I177zDsag9SwOAh+I52kJtT2Z6aM1J3NAFwKL?= =?Windows-1252?Q?STx1d6G/xm42Y//ANUNDq8hEWabuDROsxyyDCYcRnueL8Sqdzb6EGKMz?= =?Windows-1252?Q?OK+6AlFK89BqwCHqeqNgb5oV5YTwh440nrw0v9gukSnNVhRsN5X70BAJ?= =?Windows-1252?Q?g/h0cZb3BEc4D9JvziEbR9rTc501nQeIifxO8JjSgI3FRpsVlW3Tg1R+?= =?Windows-1252?Q?qeaI3XTTZcq451XQpGeuT60iLHygULLtAzdgr5KrXZSqfFriehRDaoYE?= =?Windows-1252?Q?bLp/cMME45ubNR6Hb9O6Y45HVkt18zJ4+aP9QM3ugsBBKiPbdziycU3v?= =?Windows-1252?Q?JtJZ9KaZhIZefup+bWiU96PA2/WGthb+uM73QSp3YO6RUwb8M3HQOvXY?= =?Windows-1252?Q?/eaqBxnDmdPHg0c7+iFeTT1VwlZkJ/C7dOAUR7LJVLjWyOKqqwiK+ArO?= =?Windows-1252?Q?3d7kUAZz2UjVMYt4KJJysAC8YR1hrqrNonX/Sjb81/vtb6jbVEkHBdOw?= =?Windows-1252?Q?izBMC+PGCiA2Oep2SNxsSRwJlUHkmSvQsGkLpe2T/a5n0yukKMi/A/J9?= =?Windows-1252?Q?ML00NFSwII9sw94rQpEd6TrHS0vf6Da+ijLBJdqNu4uw3CRPm9pJ9w1y?= =?Windows-1252?Q?sRGpHjK0pLpTjv6baUGjSxSC7vY+R/x6aNfRgkNDvgSooCWnsGQskDYG?= =?Windows-1252?Q?ipFi9rfF9m+Z6DFHPltr8VrESAk9JDKZITvJgmQCUVXVYQKvivnQTR6A?= =?Windows-1252?Q?DKP0y2ZmBJJ2Np7pJSsvhg+8hoi8XFIjzMZRsFwj+xNIJ1saTNXKyfye?= =?Windows-1252?Q?TIADBh9j6fsYED1NUUapRiOHsTyAH/QT50dGGM6aIXkNWjwP/0s7FFpN?= =?Windows-1252?Q?4jhgedP3upOZfFKmez9jaizu3+F1QW71rVA07b1WO+uAPSd1dBpR/l0y?= =?Windows-1252?Q?elqSCs8yE3pHOGhZeUD4Fz4wZvZ1Hu8YGKjzBkneNfs1NkUpJp8YHTOm?= =?Windows-1252?Q?AakMIaPxWwQw/AlH06529TeK78BwNdLf/K0q3oMQ32fqu9OWhudiGDzb?= =?Windows-1252?Q?QyFOSM1YiVqa/laMuqJYTdYXiEDnF8hpf1HHs5M/FvpOWLVkB+aofjaC?= =?Windows-1252?Q?P9JaAa58sR/IKEd9S737dvK0yWT3/yF2UqApufC/nptfFsrqMo2qgNp4?= =?Windows-1252?Q?ukQf5RbXNM6bYUdQHwFD6rKvodhOKO6X4VTVocMThJkGLN+WhrXxOanH?= =?Windows-1252?Q?yaj4oJlM2cPVi6r9beeZ5W/cw1ys4XyIeOG46IFjjfut2SFB+NxI/uq5?= =?Windows-1252?Q?j0bSYuh+aQCeuvMbiyL1FLf0q4v0+PpmlTHNA0ugRJK3rF0cYVExZ8u9?= =?Windows-1252?Q?iPUH1KLW01rLCmn7B5icOUPk2WHO8ZdVZ5QGcpjaSeVkdN3KNdNA1LBg?= =?Windows-1252?Q?GE++xdK8AIyNhAqFDYaPKHmL7Ba3WrH+zYKbiJlSuDY75/f1Tc+r8Gmy?= =?Windows-1252?Q?psKLnjZmpZnP1Zm//bwrk534SZQ=3D?= MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR21MB0162.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e89322d9-207d-428d-7e4c-08d9e3d99da3 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2022 10:16:44.0332 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qVOc7HUt9vlKH/6bh35Sc8iGpEdC0FkJNSimQvqlGB2TvVb2dTaHmuvai1TOHcxqtGb0ydXrnx6j2rv05699ljSoEyt8pvjkN3NdQ9GeYvI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR21MB1849 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, HTML_MESSAGE, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jan 2022 10:16:48 -0000 Thanks Jakob for the correction. Sadly, I didn=92t have any access to any n= on x86 architecture. But x86 was fully tested and there was no regression. In my spare time I will look at implementation of this for short-circuit ta= rgets. Best wishes, Navid. ________________________________ From: Jakub Jelinek Sent: Saturday, January 29, 2022 8:46:09 AM To: Richard Biener ; Jeff Law Cc: Navid Rahimi ; gcc-patches@gcc.gnu.org Subject: [EXTERNAL] [PATCH] testsuite: Fix up tree-ssa/pr103514.c testcase = [PR103514] [You don't often get email from jakub@redhat.com. Learn why this is importa= nt at http://aka.ms/LearnAboutSenderIdentification.] On Fri, Jan 28, 2022 at 03:14:16PM -0700, Jeff Law via Gcc-patches wrote: > > This patch will add the missed pattern described in bug 103514 [1] to t= he match.pd. [1] includes proof of correctness for the patch too. > > > > PR tree-optimization/103514 > > * match.pd (a & b) ^ (a =3D=3D b) -> !(a | b): New optimization. > > * match.pd (a & b) =3D=3D (a ^ b) -> !(a | b): New optimization. > > * gcc.dg/tree-ssa/pr103514.c: Testcase for this optimization. > > > > 1) https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2F= gcc.gnu.org%2Fbugzilla%2Fshow_bug.cgi%3Fid%3D103514&data=3D04%7C01%7Cna= vidrahimi%40microsoft.com%7C712766ef9fc24c7ffeda08d9e346e086%7C72f988bf86f1= 41af91ab2d7cd011db47%7C1%7C0%7C637790716153978385%7CUnknown%7CTWFpbGZsb3d8e= yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&am= p;sdata=3DCGslhJuy%2BTSrPpYbALD9pBh9945Hl6lINeHKmTEWqK0%3D&reserved=3D0 > Note the bug was filed an fixed during stage3, review just didn't happen = in > a reasonable timeframe. > > I'm going to ACK this for the trunk and go ahead and commit it for you. The testcase FAILs on short-circuit targets like powerpc64le-linux. While the first 2 functions are identical, the last two look like: : if (a_5(D) !=3D 0) goto ; [INV] else goto ; [INV] : if (b_6(D) !=3D 0) goto ; [INV] else goto ; [INV] : : # iftmp.1_4 =3D PHI <1(3), 0(4)> _1 =3D a_5(D) =3D=3D b_6(D); _2 =3D (int) _1; _3 =3D _2 ^ iftmp.1_4; _9 =3D _2 !=3D iftmp.1_4; return _9; instead of the expected: : _3 =3D a_8(D) & b_9(D); _4 =3D (int) _3; _5 =3D a_8(D) =3D=3D b_9(D); _6 =3D (int) _5; _1 =3D a_8(D) | b_9(D); _2 =3D ~_1; _7 =3D (int) _2; _10 =3D ~_1; return _10; so no wonder it doesn't match. E.g. x86_64-linux will also use jumps if it isn't just a && b but a && b && c && d (will do a & b and c & d tests and jump based on those. As it is too late to implement this optimization even for the short circuiting targets this late (not even sure which pass would be best), this patch just forces non-short-circuiting for the test. Tested on x86_64-linux -m32/-m64 and powerpc64le-linux, ok for trunk? 2022-01-29 Jakub Jelinek PR tree-optimization/103514 * gcc.dg/tree-ssa/pr103514.c: Add --param logical-op-non-short-circuit=3D1 to dg-options. --- gcc/testsuite/gcc.dg/tree-ssa/pr103514.c.jj 2022-01-29 11:11:39.3386276= 97 +0100 +++ gcc/testsuite/gcc.dg/tree-ssa/pr103514.c 2022-01-29 17:37:18.2552372= 11 +0100 @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-O -fdump-tree-optimized" } */ +/* { dg-options "-O --param logical-op-non-short-circuit=3D1 -fdump-tree-o= ptimized" } */ #include bool @@ -30,4 +30,4 @@ h (bool a, bool b) /* Make sure we have removed "=3D=3D" and "^" and "&". */ /* { dg-final { scan-tree-dump-not "&" "optimized"} } */ /* { dg-final { scan-tree-dump-not "\\^" "optimized"} } */ -/* { dg-final { scan-tree-dump-not "=3D=3D" "optimized"} } */ \ No newline at end of file +/* { dg-final { scan-tree-dump-not "=3D=3D" "optimized"} } */ Jakub