From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2062.outbound.protection.outlook.com [40.107.236.62]) by sourceware.org (Postfix) with ESMTPS id B517D3857C52 for ; Wed, 11 Nov 2020 17:42:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B517D3857C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nmekala@xilinx.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YBTQO7H68Xlt7NBdAcQZlzAveSM0H4fURUGfEyY63KtuEgJ87FnH2s/RdhnHRUGvhNk/f5OoHHNX795bhl8Qs1kUi74xPYObs68J6mLKWrf7b9axIqE59ci8x+GccGKkG17HcNcOGnaJXM61awOXNZn+gz5CZZAUTQafS/6RGB86WqckZzBmj5TU0art/7edgn1I1kMe7Dsle5PP2vc3BsyxT3f2WdNVemWQVU6fh+c98WqZjBPthA21F8m14j+MMD+oDk5gjgtvXaPfyfJm6g+9eA8L1TWAF13gU8YGr4xayWPrc1zfgJXW1NGHCn1yLUOCg1jscJblHjU98KqgDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A9kX6W2G33ThlyvgroDhlVvt5r+LrQ4AFtS2Cv3KPKg=; b=YydiYq3XsVp53qyrTgkqXMalcmD82yYSbq0sJEhlRBXCE/zZpFnf7AmNUtP4N//VZLSpu5qu8TnW0bYphjM0cETZI2Lujj7XuqCOIAUW/PU2QesuUfWXK1O6P3H9i/5t7z0dZfCpzfoOXJNBO6qEEYPadVBZfbnrqE2FNApR6z3lx6xa9zw8kMcj2U6pttHbQ41Oag0AbRU/kVAvTimB/h2zJhfLMA1AVswjsuiiKyz4MrU/bhqrmb2061fPpLtxNSCd5UQcMHk7zw9lf5gcijvJPGlYPHgGkeAFhfxeqa0V8eF9QXHngKwHHC5C0P7t+oghSbvnZtUiCs61nB3eMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A9kX6W2G33ThlyvgroDhlVvt5r+LrQ4AFtS2Cv3KPKg=; b=kVdGx+S5eaWLnV/rrxC/lPOYwNV29TJ5hdVNu2PeJZRFzFcApLn7ULeKvygyGWJTjAQaA+Eq80dzb49bttVH3CkJissBMwtrawrMY2kfoNPyofPpT2tupi/ro6iINL9hJ7OtKgUt5oBpUk0IlEA2o5bIJMGQJGLCI8Dv2NdKWaI= Received: from BY5PR02MB7041.namprd02.prod.outlook.com (2603:10b6:a03:237::10) by BYAPR02MB5271.namprd02.prod.outlook.com (2603:10b6:a03:67::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.23; Wed, 11 Nov 2020 17:42:50 +0000 Received: from BY5PR02MB7041.namprd02.prod.outlook.com ([fe80::715d:1bcc:eb2b:24f0]) by BY5PR02MB7041.namprd02.prod.outlook.com ([fe80::715d:1bcc:eb2b:24f0%8]) with mapi id 15.20.3541.025; Wed, 11 Nov 2020 17:42:50 +0000 From: Nagaraju Mekala To: Michael Eager , "gcc-patches@gcc.gnu.org" CC: Sadanand Mutyala Subject: RE: [Patch, microblaze]: Correct the const high double immediate value Thread-Topic: [Patch, microblaze]: Correct the const high double immediate value Thread-Index: Ada2WWF9c1P1FLHqSyeylhyLQYhbwgBgnK4AAB1qHyA= Date: Wed, 11 Nov 2020 17:42:50 +0000 Message-ID: References: <8d267313-d085-9906-adb9-d5629d90e28e@eagercon.com> In-Reply-To: <8d267313-d085-9906-adb9-d5629d90e28e@eagercon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: eagercon.com; dkim=none (message not signed) header.d=none;eagercon.com; dmarc=none action=none header.from=xilinx.com; x-originating-ip: [149.199.50.129] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 81605c83-b2bd-44f6-b8c9-08d8866935af x-ms-traffictypediagnostic: BYAPR02MB5271: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:478; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JlkTEgwcfayW9JnUuljkBMv1HDOwZXj2yq9bheEHzZF5LjP0MsyMuOBd5G5OBLsUWC0tekMnVsODapqxYpHmXLGRfrATTq0BdVf2V9A6IlNUVFVUHlglIbMJIJ3MzZks3dQRngnArl/a991k5bimFRLNsfpbM4qnZpZHrT8quKAW3Zk4WaSPMlymWILvw9+7TtKfTjdsyogs3Y2iLWB9r4/hQ19dIEnCz4j7OzjB36/xTPS/cYvHhQerIrmC7et0Spv9fbvnuTfHyx7Z99auHnIm+hEeSBJVo4AQuRDy8hUp4DQM/Rxe04N2ezivV3DmBARyrOnAlSdYTkC8X05Tajfb9yxsxbNqgM9OYSYwBSj36Q7rV8hvkrwLinR8E2wo x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR02MB7041.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(346002)(376002)(366004)(136003)(55016002)(107886003)(66446008)(64756008)(53546011)(83380400001)(6506007)(9686003)(26005)(110136005)(33656002)(66946007)(8676002)(76116006)(86362001)(316002)(71200400001)(8936002)(52536014)(4326008)(66556008)(7696005)(66476007)(5660300002)(478600001)(2906002)(186003)(14773001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 0zAWaQcIu2ZCpAVujZAUEEWpGhlhZ5yi/JpXJvleBklS2B19gPNluy9xaVJSiiPnH3bpnAJB8SPKtgFJXGRiJqTZ1eWYgGQs0zq2o93B1UnpTyII/zzpUFEGVWArW8n+8s0K4ibNc7UCiCd0Ns5zlIiBYY8pvgFAkD4Xs5V4VOsYFOd+a5aXR2oOoVGvyW1fuYcDE5JYVGw7QVliDIc3bN/TzhlXqGY+f3AwivCGnODV7EbXDarqTIbtXB9DYEH+cfp8RhgZo7mC2el/YIHfBrYcU3Z/Y7/BHXkxYjl5Dz8o+7sG1lcUBIdmFDosIl3Fi7iMB4Kg0cGuMwTO5305zrDmCfLx4nUfNhP2BxcVrV4r8JFejg9bMwE2HGVSjQMMyD/y6hSkuT8EG+EZVPIQj3DMtHMGoujHpkEX0mO17HRvMB3vwfZxOII8dGfmFfKFCUw/3caVsgs0dipRVhkBxQM6Tv66H/dF0M3gJwKnDm4hM4nWtzns0ic7yM8dGXuItwIBhiCV20r1Yyq30GXF+0eq5FBlA83i2KjLMS5c8tzkOtfv63hgIa1MySlNoDZAsP5WJk59hortwhJ6pEM9E6lEFxRgQ/O7n0lgGZ74aagQyRJGGwy6OEZYQxBIzxOskFOSzDWJSB+E74LKZhym3ikYB5vh5qazZ85x5wlBF3YKtj+4ulOpDaUYrgmaepx2X6fPa9pc7ktcLfFdfpAN6wfcCjZaaNP9BDdT1RSzFiEJjN7ikAEnmwt1nFhJBSrVr9nBKr/0Qmug3PvCPYTuEwbuDORm1xmfgHQ1oUPUfBaU7KuaUiPN4Y7Mlpo0fkpsxZgMCi6lbNEaz+nJtsHxl9jgPBoEsy8re2tiymZ4uuboJBDZ6/MFHROdLKAFcd67NARC8q7MZRyfM9gt7ir4Bg== Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR02MB7041.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81605c83-b2bd-44f6-b8c9-08d8866935af X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2020 17:42:50.1917 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VdQZLGrdLZEn1z90VbQAcpR7b3Uw9s16R1hA5JKY0WRJdeaKkgD+0sN3LAJtBT0TwpGtNO50PhrN9NGhmyUOiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5271 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2020 17:42:53 -0000 Hi Eager, > -----Original Message----- > From: Michael Eager > Sent: Wednesday, November 11, 2020 9:06 AM > To: Nagaraju Mekala ; Michael Eager > ; gcc-patches@gcc.gnu.org > Cc: Sadanand Mutyala > Subject: Re: [Patch, microblaze]: Correct the const high double immediate > value >=20 > On 11/8/20 9:43 PM, Nagaraju Mekala wrote: > > diff --git a/gcc/config/microblaze/microblaze.c > > b/gcc/config/microblaze/microblaze.c > > > > index a0f81b7..d9341ec 100644 > > --- a/gcc/config/microblaze/microblaze.c > > +++ b/gcc/config/microblaze/microblaze.c > > @@ -2440,15 +2440,18 @@ print_operand (FILE * file, rtx op, int > > letter) > > =A0=A0 else if (letter =3D=3D 'h' || letter =3D=3D 'j') > > =A0=A0=A0=A0 { > > -=A0=A0=A0=A0=A0 long val[2]; > > +=A0=A0=A0=A0=A0 long val[2], l[2]; > > =A0=A0=A0=A0=A0=A0 if (code =3D=3D CONST_DOUBLE) > > =A0=A0=A0=A0=A0=A0=A0 { > > =A0=A0=A0=A0=A0=A0=A0=A0=A0 if (GET_MODE (op) =3D=3D DFmode) > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 REAL_VALUE_TO_TARGET_DOUBLE > (*CONST_DOUBLE_REAL_VALUE > > (op), val); > > =A0=A0=A0=A0=A0=A0=A0=A0=A0 else > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 { > > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 val[0] =3D CONST_DOUBLE_HIGH (op)= ; > > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 val[1] =3D CONST_DOUBLE_LOW (op); > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 REAL_VALUE_TYPE rv; > > +=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0REAL_VALUE_FROM_CONST_DOUBLE (rv,= op); >=20 > REAL_VALUE_FROM_CONST_DOUBLE was removed from real.h in 2015. > Use CONST_DOUBLE_REAL_VALUE. >=20 > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 REAL_VALUE_TO_TARGET_DOUBLE (rv, = l); > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 val[1] =3D l[WORDS_BIG_ENDIAN =3D= =3D 0]; > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 val[0] =3D l[WORDS_BIG_ENDIAN != =3D 0]; > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 } > > =A0=A0=A0=A0=A0=A0=A0 } > > =A0=A0=A0=A0=A0=A0 else if (code =3D=3D CONST_INT) >=20 >=20 > > diff --git a/gcc/testsuite/gcc.target/microblaze/long.c > > b/gcc/testsuite/gcc.target/microblaze/long.c > > new file mode 100644 > > index 0000000..4d45186 > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/microblaze/long.c > > @@ -0,0 +1,10 @@ > > +/* { dg-options "-O0" } */ > > +#define BASEADDR 0xF0000000ULL > > +int main () > > +{ > > +=A0 unsigned long long start; > > +=A0 start =3D (unsigned long long) BASEADDR; > > +=A0 return 0; > > +} > > +/* { dg-final { scan-assembler > > "addik\tr(\[0-9]\|\[1-2]\[0-9]\|3\[0-1]),r0,0x00000000" } } */ > > +/* { dg-final { scan-assembler > > "addik\tr(\[0-9]\|\[1-2]\[0-9]\|3\[0-1]),r0,0xf0000000" } } */ >=20 > It looks like this test case will pass without the patch. The code > generated before applying the patch is > addik r4,r0,0x00000000 > addik r5,r0,0xf0000000 #li =3D> la >=20 > Can you provide a test case which fails without the patch but passes > with the patch? Thanks for reviewing the patch, I will update both patch and testcase and r= e-submit them. Thanks, Nagaraju >=20 > -- > Michael Eager