From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80795 invoked by alias); 10 Feb 2020 03:28:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 80787 invoked by uid 89); 10 Feb 2020 03:28:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=independently, summaries, (unknown) X-HELO: NAM12-BN8-obe.outbound.protection.outlook.com Received: from mail-bn8nam12on2135.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) (40.107.237.135) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Feb 2020 03:28:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S0V3kC2WKak2HFDzNxio9Pdtan8UpSM+PPv8HW64gQDG3cdbtvz1I3U2IfzsyJdrlwyuaiHm75p86fDQqMNqXn9qCabPDUfMdLaD7UjED+qugtV2Tp9B8M5Vff1z3RnAtC3i1UwAVp23Ssuj71z4Kka7EXEo4h47fu+zWJuDd4NGCOl8/W+uTrfcocCCBJBKw+hW35SL3lehzQAWINAGXYuhEQe3vOkhzlifPoU4bqw/XosFn73yXjnSB0FeiDnAxe2biJ9Fgx4j42wNOKTs0hlYtPfVouJoaA66asKI2T9AwqIhFmFvV3SNViLVoGWedCHCJii1hYE4gMM0dA6FDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=54YDoA9XyhOI/XRcAtIM+AMAoDHtOqCABYcoKIdtPgY=; b=XFFxMDJFGEATf6t8OCD7Z1sCKsH8jJgQNimYWFszmMwYF2WsSbtKpVvzEzPxhlWRJWMZlmcOUbrhOosMNsacpiuFBHcnCn0pKOvbVI6sXOoLptuCA3wZ5CqXNTbmGaw9WF1qlaSXCvsx1SEyH0AKYMfDj6K8sSyWJ9AAW7ypJoTyRiEfmwgR8dDfUDy+902NMKgB2vQCDAFPcOGqNWqHU/Uhxw8XqUyUmsx6nFhAit9u9tOyWONPvc1i1Vspg4J/5HGiku6e4hUCHCVZYvvAw8hJz+EwGCPMSWrbXjTtnoYDnnJOxkCZywY8ZanimdMW76q/RzzWFfSkm72f6PQ/ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=54YDoA9XyhOI/XRcAtIM+AMAoDHtOqCABYcoKIdtPgY=; b=YWvX031Da7+wUiHhr2KD8xa76W+qGeD5ANCG7pd6d4rGlTs2y+DJsmIBSCjKCchNgeHxJCqkSFBOAmXaKGuziEKwnF19/epYGpwn3Klzv+t5g6nfH2tWL2u01ntF0nI/uSF9aDk5n0TVxA282fWgamhsQg7uQR/ycRkUtRccIkM= Received: from BYAPR01MB4869.prod.exchangelabs.com (20.177.226.139) by BYAPR01MB4566.prod.exchangelabs.com (20.178.0.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.26; Mon, 10 Feb 2020 03:28:47 +0000 Received: from BYAPR01MB4869.prod.exchangelabs.com ([fe80::b092:f9fd:5516:bba]) by BYAPR01MB4869.prod.exchangelabs.com ([fe80::b092:f9fd:5516:bba%7]) with mapi id 15.20.2707.028; Mon, 10 Feb 2020 03:28:47 +0000 From: Feng Xue OS To: Martin Jambor , Jan Hubicka , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH V2] Generalized value pass-through for self-recursive function (ipa/pr93203) Date: Mon, 10 Feb 2020 03:28:00 -0000 Message-ID: References: , In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=fxue@os.amperecomputing.com; x-ms-oob-tlc-oobclassifiers: OLM:10000; received-spf: None (protection.outlook.com: os.amperecomputing.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-messagedata: 1U4F98do9CBlLYaMRTNxeuVAj3HNDLmxcaG8YnDm07qFh2U3iYOm9pZKSbnTVsHq2/483MA8FXgv9+nJBvfAPFtH6QzyYHi+zkLZbxMfXioZXPVOVOl+iv9X02roZiQC2v7cwEsM1a9axHFwNVGvraWxYRLoWM6oc/XstqULUiQ5ynmaKY3KwGQOYyI0/LuhFSwYo6Tg5K+tH9nk2GpbCA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lb+QGcVdOblc0H8oPSTZUblipjqn9I+zeBKwGkqVqytGjfONAVV7Y8O2I3eMY6Fyh+niHhLkd8IU6C5iJbs4UtyUTHRU0MUxKcS9AKi+XNI= X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00515.txt.bz2 >> - gcc_checking_assert (item->value); > I've been staring at this for quite a while, trying to figure out how > your patch can put NULL here before I realized it was just a clean-up > :-) Sending such changes independently or pointing them out in the > email/ChangeLog makes review easier. Ok. I'll add some description on this cleanup on ChangeLog. >> @@ -5564,7 +5610,6 @@ decide_whether_version_node (struct cgraph_node *n= ode) >> } >> clone =3D create_specialized_node (node, known_csts, known_contex= ts, >> aggvals, callers); >> - info =3D IPA_NODE_REF (node); > please either drop this change or change it to: > > gcc_checking_assert (info =3D=3D IPA_NODE_REF (node)); > this line of code was actually necessary when adding nodes possibly > invalidated addresses of all summaries - like fast_function_summary > classes still do. So if we ever decide to use fast summaries we need a > test to remind us that info address must be obtained again. Ok. I'm not aware that, will keep the line as original. Thanks, Feng