From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 65BC73858CD1 for ; Sun, 26 Nov 2023 16:42:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 65BC73858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 65BC73858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::631 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701016970; cv=none; b=ovA0WHBLgQoBVtf4aHJH2nRsSsdatvF/I8x2mFyGzTUtLeoqsS3MldEuo9ngGoxGgc10Ari09S05GNtA5cgG+Smz82vhNItLJQ2gNIpq3QX8BvVKQYP8u5xi4i3d8npdexdA2zdg60N2QUbPJD2BVLwqVjks5JlFrbiOh8hSUbI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701016970; c=relaxed/simple; bh=lNUhlgWbUzfafNaAQJsZuQ2Fit/+LP2tjgMPHCSSclU=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=KdBFQZxcoKu6TNsqURfIp3OO25dkQ/mLID/eNkGs+YletMhn8HpQSfRY7nXmHWZO0pawkgGPREpE5ovfk8JkbuNqujzYaNR1jTDyei9JMJK5Jp7AZl0+0hKDfaix1g5WvOunbj8bXFSO917ZtXEt7c1Y/0t2VnfersdvROYJXvo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a011e9bf336so469773266b.3 for ; Sun, 26 Nov 2023 08:42:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701016967; x=1701621767; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=yY22/N81+wE5UKup2g2V84nt6x7ZElEr+UT30LwmfMA=; b=aoARfBDXECJfbIS/W6XkRqbpDmGWN206GtY9B9MlLS7K6BBjVrd8/9rLmDlg6PO/al y0WW7zWV/PbLY66O6iawheNntNV3lSYCEvpA92LFOAMEKc8Vap0pSZP+jKEEGhiHF9N6 MWTuvT6smIo4oYzynjyXBitLBND+qu4Wt3Y5nYQCNrJdWuwEpirtqo14B4yD7reDP4ng EE/OKlBsFeLVp904wy+Qq3oBJC3qkb2pCprxiBAIjF8J7lMHn8gr5bivt9NoLCicmP2o /Z5DcH7HwrpoiYDBkBwGV3J7L574A8N7LVsLYheVuSaLOKPMzof4B3w2qrga74Azyln9 W54A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701016967; x=1701621767; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yY22/N81+wE5UKup2g2V84nt6x7ZElEr+UT30LwmfMA=; b=rUuTDnpLyL4stu5ePWiOOHAuwnR0CblWszpqajfwSpW+I46tJ8GGEeIi2ayczX1YM5 kOg5M2FU60/5zBKVbpMll+CD74b82IIhelSsPYtdVrL/HJ/NVowC95+FWAv9f+Hk25bO HL1OH+gFs+2bg9Yr+lst3yh15eru8XjONnOIT5qxoqEX3pSHp2QRn1zVWuqPsbdApgUI uIC8e6quGtTcDeHYXq62oHzRWYTIF05XQIyyJ3Uv+C+/5mnpPhTVJAVKF+YkEwNvSTMR Bq3v8bWdcdVDtafrFZjPE/RrYSGPOI824Bj9mvsbeERrdh0Vy8T++tcKuT4pZpGSSqN4 vDgg== X-Gm-Message-State: AOJu0YwnpTYOvHtqgwEXWDGHmhjgzXANfSYPmZ8oE57qZ6+q+pR5Yi20 60AV1GNzDc32QE3uOyq50x+i+//P6IY= X-Google-Smtp-Source: AGHT+IHkTWdtVdsqxid2w9NAJVouyQb/g0oXuEhBbTSEw9HfjzWuDE+SSSQhHaR3uduxwm33iu1lYw== X-Received: by 2002:a17:907:1ca1:b0:9bd:a7a5:3a5a with SMTP id nb33-20020a1709071ca100b009bda7a53a5amr7065497ejc.36.1701016966478; Sun, 26 Nov 2023 08:42:46 -0800 (PST) Received: from ?IPv6:::1? ([2001:871:227:b560:60ca:6398:bdf7:7d6c]) by smtp.gmail.com with ESMTPSA id b10-20020a1709063f8a00b009f8af454d0dsm4692677ejj.112.2023.11.26.08.42.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Nov 2023 08:42:45 -0800 (PST) Date: Sun, 26 Nov 2023 17:42:40 +0100 From: rep.dot.nop@gmail.com To: gcc-patches@gcc.gnu.org, Jeff Law , Dimitar Dimitrov , Jeff Law CC: "gcc-patches@gcc.gnu.org" , Jivan Hakobyan Subject: Re: [RFA] New pass for sign/zero extension elimination In-Reply-To: References: <6d5f8ba7-0c60-4789-87ae-68617ce6ac2c@ventanamicro.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22 November 2023 23:23:41 CET, Jeff Law wrote: > > >On 11/20/23 11:56, Dimitar Dimitrov wrote: >> On Sun, Nov 19, 2023 at 05:47:56PM -0700, Jeff Law wrote: >> =2E=2E=2E >>> + enum rtx_code xcode =3D GET_CODE (x); >>> + if (xcode =3D=3D SET) >>> + { >>> + const_rtx dst =3D SET_DEST (x); >>> + rtx src =3D SET_SRC (x); >>> + const_rtx y; >>> + unsigned HOST_WIDE_INT bit =3D 0; >>> + >>> + /* The code of the RHS of a SET=2E */ >>> + enum rtx_code code =3D GET_CODE (src); >>> + >>> + /* ?!? How much of this should mirror SET handling, potentially >>> + being shared? */ >>> + if (SUBREG_BYTE (dst)=2Eis_constant () && SUBREG_P (dst)) >>=20 >> Shouldn't SUBREG_P be checked first like: >> if (SUBREG_P (dst) && SUBREG_BYTE (dst)=2Eis_constant ()) >Yes, absolutely=2E It'll be fixed in the next update=2E > >This also highlighted that I never added pru-elf to the configurations in= my tester=2E I remember thinking that it needed to be added, but obviousl= y that mental TODO got lost=2E I've just fixed that=2E And please drop the superfluous enum from rtx_code while at it? TIA