From: Simon Wright <simon@pushface.org>
To: Iain Sandoe <iain@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR target/80556
Date: Mon, 18 Sep 2017 21:08:00 -0000 [thread overview]
Message-ID: <C0E30AC7-FF9F-4448-9842-42A49C7E309B@pushface.org> (raw)
In-Reply-To: <0505A96C-0C2F-4A7C-8CEC-68BCC11DA169@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 1690 bytes --]
On 18 Sep 2017, at 21:09, Iain Sandoe <iain@codesourcery.com> wrote:
>
> Hi Simon,
>
>> On 29 Jun 2017, at 21:41, Simon Wright <simon@pushface.org> wrote:
>>
>> On 28 Jun 2017, at 18:40, Jeff Law <law@redhat.com> wrote:
>>>
>>> On 06/09/2017 07:57 AM, Simon Wright wrote:
>>>> 2017-06-09 Simon Wright <simon@pushface.org>
>>>>
>>>> PR target/80556
>>>> * configure.ac (stage1_ldflags): For Darwin, include -lSystem.
>>>> (poststage1_ldflags): likewise.
>>>> * configure: regenerated.
>>> I'm a bit confused here. Isn't -lSystem included in darwin's LIB_SPEC
>>> in which case the right things ought to already be happening, shouldn't it?
>>
>> The specs that involve -lSystem are
>
>> I've rebuilt gcc-8-20170528 with this change alone (i.e. not the patch currently posted here), successfully.
>>
>> If I propose this alternative patch, should it be a new post, or should I continue this thread?
>
> thanks for the patch.
>
> The basic idea seems sound - as a workaround (as noted in comment #20 in the PR, we should really rationalise the libgcc/crts stuff to reflect the modern world, but these things take time...).
>
> The patch as you have it would apply to every version of Darwin.
>
> AFAICT from the published sources, i386 Darwin should be able to work with the libgcc unwinder (and all earlier Darwin *have* to) - so I’ve proposed a modified patch in the PR that makes the changes specific to m64 x86 and doesn’t make any alteration for PPC and/or Darwin < 10.
That sounds like the right thing to do. I hadn't considered the older hardware/os issues (I only have kit back to macOS 10.11, Darwin 15).
next prev parent reply other threads:[~2017-09-18 21:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 13:57 Simon Wright
2017-06-28 17:40 ` Jeff Law
2017-06-29 20:41 ` Simon Wright
2017-09-01 13:03 ` Simon Wright
2017-09-18 20:10 ` Iain Sandoe
2017-09-18 21:08 ` Simon Wright [this message]
2017-09-22 9:55 ` Iain Sandoe
2017-09-24 16:06 ` Mike Stump
2017-06-28 21:36 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C0E30AC7-FF9F-4448-9842-42A49C7E309B@pushface.org \
--to=simon@pushface.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).