From: FX <fxcoudert@gmail.com>
To: gcc-patches@gcc.gnu.org
Cc: Harald Anlauf <anlauf@gmx.de>,
fortran@gcc.gnu.org, hjl.tools@gmail.com, schwab@suse.de
Subject: Re: [PATCH] Fortran: make IEEE_CLASS recognize signaling NaNs
Date: Wed, 12 Jan 2022 11:23:43 +0100 [thread overview]
Message-ID: <C1111E8E-6287-4593-A3E3-629068C06850@gmail.com> (raw)
In-Reply-To: <2AC9FA3C-2E70-4A5B-B612-FDF0E00BA845@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]
Hi,
I can confirm that I don’t see this failure on a Debian bullseye/sid (Linux 5.11.0-46, glibc 2.31-0ubuntu9.2) with a fresh bootstrap of master:
$ grep signaling testsuite/gfortran/gfortran.sum
PASS: gfortran.dg/ieee/signaling_1.f90 -O0 (test for excess errors)
PASS: gfortran.dg/ieee/signaling_1.f90 -O0 execution test
PASS: gfortran.dg/ieee/signaling_1.f90 -O1 (test for excess errors)
PASS: gfortran.dg/ieee/signaling_1.f90 -O1 execution test
PASS: gfortran.dg/ieee/signaling_1.f90 -O2 (test for excess errors)
PASS: gfortran.dg/ieee/signaling_1.f90 -O2 execution test
PASS: gfortran.dg/ieee/signaling_1.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (test for excess errors)
PASS: gfortran.dg/ieee/signaling_1.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions execution test
PASS: gfortran.dg/ieee/signaling_1.f90 -O3 -g (test for excess errors)
PASS: gfortran.dg/ieee/signaling_1.f90 -O3 -g execution test
PASS: gfortran.dg/ieee/signaling_1.f90 -Os (test for excess errors)
PASS: gfortran.dg/ieee/signaling_1.f90 -Os execution test
It’s showing on some gcc-testresults for x86_64 and aarch64 linux, so I’ll need someone (HJ, Andreas are in CC) to show me what the error is.
It may be related to the use of dg-options instead of dg-additional-options in that testcase, so I pushed the attached fix. I’ll check the test results mailing-list to see if it improved things (or confirm when the error message is posted).
FX
[-- Attachment #2: test.patch --]
[-- Type: application/octet-stream, Size: 1187 bytes --]
commit 6b14100b9504800768da726dcb81f1857db3b493
Author: Francois-Xavier Coudert <fxcoudert@gmail.com>
Date: 2022-01-12 11:19:37 +0100
Fortran: fix testcase compiler flags
-fsignaling-nans is already passed by ieee.exp, so it's not needed.
We must use dg-additional-options instead of dg-options, otherwise we
override flags passed from ieee.exp. And we need to use -w because
some options only make sense for the Fortran source.
gcc/testsuite/ChangeLog:
* gfortran.dg/ieee/signaling_1.f90: Adjust flags.
diff --git a/gcc/testsuite/gfortran.dg/ieee/signaling_1.f90 b/gcc/testsuite/gfortran.dg/ieee/signaling_1.f90
index a1403e6ce16..3d846fc1038 100644
--- a/gcc/testsuite/gfortran.dg/ieee/signaling_1.f90
+++ b/gcc/testsuite/gfortran.dg/ieee/signaling_1.f90
@@ -1,7 +1,9 @@
! { dg-do run }
! { dg-require-effective-target issignaling } */
! { dg-additional-sources signaling_1_c.c }
-! { dg-options "-fsignaling-nans" }
+! { dg-additional-options "-w" }
+! the -w option is needed to make f951 not report a warning for
+! the -fintrinsic-modules-path option passed by ieee.exp
!
program test
use, intrinsic :: iso_c_binding
next prev parent reply other threads:[~2022-01-12 10:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-02 10:50 FX
2022-01-09 10:52 ` FX
2022-01-09 19:34 ` Mikael Morin
2022-01-10 12:04 ` FX
2022-01-11 22:01 ` Harald Anlauf
2022-01-11 22:04 ` FX
2022-01-11 22:11 ` Harald Anlauf
2022-01-11 22:32 ` FX
2022-01-12 10:23 ` FX [this message]
2022-01-12 10:34 ` Jakub Jelinek
2022-01-12 11:03 ` FX
2022-01-12 11:06 ` Jakub Jelinek
2022-01-12 11:55 ` FX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C1111E8E-6287-4593-A3E3-629068C06850@gmail.com \
--to=fxcoudert@gmail.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).