From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-494364-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 125180 invoked by alias); 19 Jan 2019 21:56:56 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 125136 invoked by uid 89); 19 Jan 2019 21:56:55 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: Yes, score=5.1 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPAM_BODY autolearn=no version=3.3.2 spammy=D*netcologne.de, tkoenig@netcologne.de, tkoenignetcolognede, H*i:sk:b4206a4
X-HELO: nef.ens.fr
Received: from nef2.ens.fr (HELO nef.ens.fr) (129.199.96.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 19 Jan 2019 21:56:54 +0000
X-ENS-nef-client: 129.199.120.1
Received: from mailhost.lps.ens.fr (tournesol.lps.ens.fr [129.199.120.1])          by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id x0JLupY1003811          ; Sat, 19 Jan 2019 22:56:51 +0100
Received: from localhost (localhost [127.0.0.1])	by mailhost.lps.ens.fr (Postfix) with ESMTP id 023FBE1;	Sat, 19 Jan 2019 22:56:51 +0100 (CET)
Received: from mailhost.lps.ens.fr ([127.0.0.1])	by localhost (tournesol.lps.ens.fr [127.0.0.1]) (amavisd-new, port 10024)	with ESMTP id 67BesXX_Z0sR; Sat, 19 Jan 2019 22:56:50 +0100 (CET)
Received: from [192.168.1.11] (log78-1-82-242-47-10.fbx.proxad.net [82.242.47.10])	by mailhost.lps.ens.fr (Postfix) with ESMTPSA id B8F7FD4;	Sat, 19 Jan 2019 22:56:50 +0100 (CET)
Content-Type: text/plain;	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [Patch, Fortran] PR 37835 -fno-automatic does not work for derived types with default initalizer
From: =?utf-8?Q?Dominique_d=27Humi=C3=A8res?= <dominiq@lps.ens.fr>
In-Reply-To: <b4206a4e-6ffb-5902-d9f6-e86ab4fdb570@netcologne.de>
Date: Sat, 19 Jan 2019 21:56:00 -0000
Cc: Paul Richard Thomas <paul.richard.thomas@gmail.com>,        gfortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C1F710F8-BA67-43B3-AFD1-96F0FBB8EC53@lps.ens.fr>
References: <49BC4E41-05B8-40A4-8F1E-4DDB12D645AE@lps.ens.fr> <b4206a4e-6ffb-5902-d9f6-e86ab4fdb570@netcologne.de>
To: Thomas Koenig <tkoenig@netcologne.de>
X-SW-Source: 2019-01/txt/msg01133.txt.bz2

Thanks for the review, committed as r268098.

Dominique

> Le 19 janv. 2019 =C3=A0 16:50, Thomas Koenig <tkoenig@netcologne.de> a =
=C3=A9crit :
>=20
> Hi Dominique,
>=20
>> The patch for gcc/fortran/resolve.c is the modernized version of Paul=E2=
=80=99s patch in comment 4.
>> It causes some regressions due to "Duplicate SAVE =C2=BB warnings.
>> They are silenced by the patch for gcc/fortran/symbol.c unless -pedantic=
 is used as documented
>> in the change for gcc/fortran/invoke.texi.
>> Is it OK for trunk?
>=20
> I assume you did a regression test. OK if this has passed.

I have never submitted a patch without regtesting it!

>=20
> Thanks for the patch!
>=20
> Regards
>=20
> 	Thomas