[PATCH] ARC: configure script to allow non uclibc based triplets

[PATCH] ARC: configure script to allow non uclibc based triplets

[Vineet Gupta]

gcc/
2016-05-20  Vineet Gupta <vgupta@synopsys.com>

    * config.gcc: Remove uclibc from arc target spec

Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
 gcc/config.gcc     | 2 +-
 libgcc/config.host | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/config.gcc b/gcc/config.gcc
index 9ca5c6ed71d8..f88d1dfa23df 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -889,7 +889,7 @@ arc*-*-elf*)
 	big*)	tm_defines="DRIVER_ENDIAN_SELF_SPECS=\\\"%{!EL:%{!mlittle-endian:-mbig-endian}}\\\" ${tm_defines}"
 	esac
 	;;
-arc*-*-linux-uclibc*)
+arc*-*-linux*)
 	extra_headers="arc-simd.h"
 	tm_file="arc/arc-arch.h dbxelf.h elfos.h gnu-user.h linux.h glibc-stdint.h ${tm_file}"
 	tmake_file="${tmake_file} arc/t-arc-uClibc arc/t-arc"
diff --git a/libgcc/config.host b/libgcc/config.host
index e7683898f82b..d3c9c71bb042 100644
--- a/libgcc/config.host
+++ b/libgcc/config.host
@@ -322,7 +322,7 @@ arc*-*-elf*)
 	tmake_file="arc/t-arc-newlib arc/t-arc"
 	extra_parts="crti.o crtn.o crtend.o crtbegin.o crtendS.o crtbeginS.o libgmon.a crtg.o crtgend.o crttls_r25.o crttls_r30.o"
 	;;
-arc*-*-linux-uclibc*)
+arc*-*-linux*)
 	tmake_file="${tmake_file} t-slibgcc-libgcc t-slibgcc-nolc-override arc/t-arc700-uClibc arc/t-arc"
 	extra_parts="crti.o crtn.o crtend.o crtbegin.o crtendS.o crtbeginS.o libgmon.a crtg.o crtgend.o"
 	;;
-- 
2.5.0

RE: [PATCH] ARC: configure script to allow non uclibc based triplets

[Claudiu Zissulescu]

Hi Vineet,

> gcc/
> 2016-05-20  Vineet Gupta <vgupta@synopsys.com>
> 
>     * config.gcc: Remove uclibc from arc target spec
> 
> -arc*-*-linux-uclibc*)
> +arc*-*-linux*)

Actually may make sense to have something like arc*-*-*linux-glibc* here (or something of a sort) as we can properly select gcc driver configurations for each system, as ARM for example does.

//Claudiu

Re: [PATCH] ARC: configure script to allow non uclibc based triplets

[Vineet Gupta]

On Friday 20 May 2016 05:28 PM, Claudiu Zissulescu wrote:
> Hi Vineet,
>
>> gcc/
>> 2016-05-20  Vineet Gupta <vgupta@synopsys.com>
>>
>>     * config.gcc: Remove uclibc from arc target spec
>>
>> -arc*-*-linux-uclibc*)
>> +arc*-*-linux*)
> Actually may make sense to have something like arc*-*-*linux-glibc* here (or something of a sort) as we can properly select gcc driver configurations for each system, as ARM for example does.

I didn't see any explicit glibc suffixes in the switch case for other arches hence
the above.

Actually autoconf automatically defines LIBC_{GLIBC,UCLIBC} based on the triplet -
so u get the desired multiplexer for driver configuration already - although I
doubt differences will be needed for ARC for uclibc/glibc !

In light of above, Cupertino pointed me another thing which we need fixing -
something like below

diff --git a/gcc/config/arc/arc.h b/gcc/config/arc/arc.h
index 44f812dfdbe9..10329524c710 100644
--- a/gcc/config/arc/arc.h
+++ b/gcc/config/arc/arc.h
@@ -77,7 +77,7 @@ along with GCC; see the file COPYING3.  If not see
 /* Names to predefine in the preprocessor for this target machine.  */
 #define TARGET_CPU_CPP_BUILTINS() arc_cpu_cpp_builtins (pfile)
 
-#if DEFAULT_LIBC == LIBC_UCLIBC
+#if (DEFAULT_LIBC == LIBC_UCLIBC) || (DEFAULT_LIBC == LIBC_GLIBC) ||
(DEFAULT_LIBC == LIBC_BIONIC)
 
 #define TARGET_OS_CPP_BUILTINS() \
   do \

RE: [PATCH] ARC: configure script to allow non uclibc based triplets

[Claudiu Zissulescu]

Approved and applied.

Cheers,
Claudiu

> -----Original Message-----
> From: Vineet Gupta
> Sent: Friday, May 20, 2016 7:02 AM
> To: gcc-patches@gcc.gnu.org
> Cc: Claudiu Zissulescu <claziss@synopsys.com>; gnu@amylaar.uk;
> Francois.Bedard@synopsys.com; Vineet Gupta <vgupta@synopsys.com>
> Subject: [PATCH] ARC: configure script to allow non uclibc based triplets
> 
> gcc/
> 2016-05-20  Vineet Gupta <vgupta@synopsys.com>
> 
>     * config.gcc: Remove uclibc from arc target spec
> 
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
> ---
>  gcc/config.gcc     | 2 +-
>  libgcc/config.host | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gcc/config.gcc b/gcc/config.gcc
> index 9ca5c6ed71d8..f88d1dfa23df 100644
> --- a/gcc/config.gcc
> +++ b/gcc/config.gcc
> @@ -889,7 +889,7 @@ arc*-*-elf*)
>  	big*)
> 	tm_defines="DRIVER_ENDIAN_SELF_SPECS=\\\"%{!EL:%{!mlittle-
> endian:-mbig-endian}}\\\" ${tm_defines}"
>  	esac
>  	;;
> -arc*-*-linux-uclibc*)
> +arc*-*-linux*)
>  	extra_headers="arc-simd.h"
>  	tm_file="arc/arc-arch.h dbxelf.h elfos.h gnu-user.h linux.h glibc-
> stdint.h ${tm_file}"
>  	tmake_file="${tmake_file} arc/t-arc-uClibc arc/t-arc"
> diff --git a/libgcc/config.host b/libgcc/config.host
> index e7683898f82b..d3c9c71bb042 100644
> --- a/libgcc/config.host
> +++ b/libgcc/config.host
> @@ -322,7 +322,7 @@ arc*-*-elf*)
>  	tmake_file="arc/t-arc-newlib arc/t-arc"
>  	extra_parts="crti.o crtn.o crtend.o crtbegin.o crtendS.o crtbeginS.o
> libgmon.a crtg.o crtgend.o crttls_r25.o crttls_r30.o"
>  	;;
> -arc*-*-linux-uclibc*)
> +arc*-*-linux*)
>  	tmake_file="${tmake_file} t-slibgcc-libgcc t-slibgcc-nolc-override
> arc/t-arc700-uClibc arc/t-arc"
>  	extra_parts="crti.o crtn.o crtend.o crtbegin.o crtendS.o crtbeginS.o
> libgmon.a crtg.o crtgend.o"
>  	;;
> --
> 2.5.0