From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from st43p00im-zteg10071901.me.com (st43p00im-zteg10071901.me.com [17.58.63.169]) by sourceware.org (Postfix) with ESMTPS id 9C5123856DD6 for ; Mon, 15 May 2023 19:59:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9C5123856DD6 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=icloud.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1684180774; bh=CaYEUrBplvZOLFBtl2+SPxwa4nrbGy4i/1/DMO9Sgzs=; h=From:Message-Id:Content-Type:Mime-Version:Subject:Date:To; b=O3WNpfi+PA2ij83PTt3ILzhUc3JJ+SxJkNmMSq0dLSXHWZCjURO3CpCXa5zSspZ2d mPPlQO+LyEooHBt3UBfkCZHOmDgTNMiZBBfsgk5cIUVxCyMGFtN1xvwRmbvXonHCdj ImGkcKkqwAq1YFI3qnCaLxVHf2i4A0GGDxFKi0LyODMpLxgc4Cw/Fyvan1OBE6SslA C5cW/6j6/PJY8ttBINWXjapwS12VbzRIx8irbXzCA0TppJL5kwXavOibhyLpwV4AsX VncXKRCddC2LpEg/nN/jGfeFpsORURA/JlW6uZ43H2+GXTdnBImPV7baVpvgqlMXjm shCAotBHoyX9g== Received: from smtpclient.apple (st43p00im-dlb-asmtp-mailmevip.me.com [17.42.251.41]) by st43p00im-zteg10071901.me.com (Postfix) with ESMTPSA id 588F7840473; Mon, 15 May 2023 19:59:34 +0000 (UTC) From: Evandro Menezes Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_A7BBDB69-59E2-462C-B0E2-6BB3BEA012CA" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Subject: Re: [PATCH] aarch64: Add SVE instruction types Date: Mon, 15 May 2023 14:59:02 -0500 In-Reply-To: Cc: Evandro Menezes via Gcc-patches , Kyrylo Tkachov , Tamar Christina To: Richard Sandiford References: <1D567E08-9EBB-4EF7-9626-BA95D8E0EB36@icloud.com> X-Mailer: Apple Mail (2.3731.500.231) X-Proofpoint-ORIG-GUID: Ho1y3h__0Xp9pH1-xcoM4ozvI55MHR-K X-Proofpoint-GUID: Ho1y3h__0Xp9pH1-xcoM4ozvI55MHR-K X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.138,18.0.816,17.11.62.513.0000000_definitions?= =?UTF-8?Q?=3D2022-01-17=5F04:2020-02-14=5F02,2022-01-17=5F04,2021-12-02?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 clxscore=1015 mlxlogscore=999 bulkscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2305150165 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FREEMAIL_REPLY,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --Apple-Mail=_A7BBDB69-59E2-462C-B0E2-6BB3BEA012CA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi, Richard. My criteria were very much (a). In some cases though, a particular instruc= tion could have variations that others in its natural group didn=E2=80=99t,= when if seemed sensible to create a specific description for this instruct= ion, even if its base form shares resources with other instructions in its = group. Do you have specific instances in mind? Thank you, --=20 Evandro Menezes > Em 15 de mai. de 2023, =C3=A0(s) 04:00, Richard Sandiford escreveu: >=20 > Evandro Menezes via Gcc-patches writes: >> This patch adds the attribute `type` to most SVE1 instructions, as in th= e other >> instructions. >=20 > Thanks for doing this. >=20 > Could you say what criteria you used for picking the granularity? Other > maintainers might disagree, but personally I'd prefer to distinguish two > instructions only if: >=20 > (a) a scheduling description really needs to distinguish them or > (b) grouping them together would be very artificial (because they're > logically unrelated) >=20 > It's always possible to split types later if new scheduling descriptions > require it. Because of that, I don't think we should try to predict ahead > of time what future scheduling descriptions will need. >=20 > Of course, this depends on having results that show that scheduling > makes a significant difference on an SVE core. I think one of the > problems here is that, when a different scheduling model changes the > performance of a particular test, it's difficult to tell whether > the gain/loss is caused by the model being more/less accurate than > the previous one, or if it's due to important "secondary" effects > on register live ranges. Instinctively, I'd have expected these > secondary effects to dominate on OoO cores. >=20 > Richard --=20 Evandro Menezes =E2=97=8A evandro@yahoo.com =E2=97=8A Austin, TX =CE=86=CE=B3=CE=B9=CE=BF=CF=82 =CE=BF =CE=98=CE=B5=CF=8C=CF=82 =E2=81=82 = =DC=A9=DC=95=DC=9D=DC=AB=DC=90 =DC=90=DC=A2=CC=B1=DC=AC =DC=A0=DC=90 =DC=A1= =DC=9D=DC=98=DC=AC=DC=90 =E2=81=82 Sanctus Deus --Apple-Mail=_A7BBDB69-59E2-462C-B0E2-6BB3BEA012CA--